[dynamo, nested graph breaks] disable nested graph breaks in generators; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py #165809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mo/test_ctx_manager.py [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165809
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 910701f with merge base a988510 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
topic: not user facing
This was referenced Oct 18, 2025
…n test/dynamo/test_ctx_manager.py" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Lucaskabela
approved these changes
Oct 20, 2025
Contributor
Lucaskabela
left a comment
Lucaskabela
left a comment
There was a problem hiding this comment.
LGTM with clear semantics here :)
…n test/dynamo/test_ctx_manager.py" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
williamwen42
changed the title
test/dynamo/test_ctx_manager.py
Outdated
| super().tearDown() | ||
| torch._dynamo.config.enable_trace_contextlib = self._prev | ||
| torch._dynamo.config.enable_trace_unittest = self._u_prev | ||
| torch._dynamo.config.nested_graph_breaks = False |
Collaborator
There was a problem hiding this comment.
Shouldn't you save the previous value? Otherwise, you may falsify a flag that was originally True.
…in generators; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py" Generators should not support nested graph breaks. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…in generators; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py" Generators should not support nested graph breaks. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
guilhermeleobas
approved these changes
Oct 21, 2025
…in generators; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py" Generators should not support nested graph breaks. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #166016 |
Khanaksahu
pushed a commit
to Khanaksahu/pytorch-fork
that referenced
this pull request
Nov 17, 2025
…rs; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py ghstack-source-id: bb4bb3c Pull Request resolved: pytorch/pytorch#165809
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
…mo/test_ctx_manager.py ghstack-source-id: 1e78191 Pull Request resolved: pytorch/pytorch#165809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Generators should not support nested graph breaks.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela