Skip to content

Check for released variables in SavedVariable::unpack() #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
May 25, 2017
Merged

Check for released variables in SavedVariable::unpack() #1648

soumith merged 1 commit into from
May 25, 2017

Conversation

@colesbury
Copy link
Member

@colesbury colesbury commented May 25, 2017

Fixes #1288

@colesbury
Copy link
Member Author

colesbury commented May 25, 2017

See also #1293, but I moved the check into the Variable unpacking code so that we're more likely to catch these errors in new C++ autograd functions.

@ezyang
Copy link
Contributor

ezyang commented May 25, 2017

LGTM.

@soumith soumith merged commit 036c3f9 into pytorch:master May 25, 2017
@colesbury colesbury deleted the backward_twice branch June 5, 2017 18:03
houseroad added a commit to houseroad/pytorch that referenced this pull request Feb 16, 2019
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to ab1c57eed31c75df8c6fbad998a0b89e38…
58004d1 
…8786a4

Summary:
Previous import was 822d8df0a2a32233c6022f50a158817a0f19bdc7

Included changes:
- **[ab1c57e](onnx/onnx@ab1c57e)**: [ONNXIFI]Add extension to be implementable (pytorch#1796) <Rui Zhu>
- **[b92eee8](onnx/onnx@b92eee8)**: Revert "Implement Op Annotation's for ONNX (pytorch#1648)" (pytorch#1812) <Ke Zhang>
- **[61f1e9e](onnx/onnx@61f1e9e)**: Enable ONNX_ML by default (pytorch#1810) <Shinichiro Hamaji>
- **[4f064a1](onnx/onnx@4f064a1)**: fix Greater and Less doc (pytorch#1811) <Guoliang Hua>
- **[0628582](onnx/onnx@0628582)**: Implement Op Annotation's for ONNX (pytorch#1648) <Armen>
- **[ad9d2f7](onnx/onnx@ad9d2f7)**: Versioning doc update for Opset 9 (pytorch#1805) <Vinitra Swamy>
- **[e71e3be](onnx/onnx@e71e3be)**: add dilation case for ConvTranspose op (pytorch#1797) <Randy>

Differential Revision: D14114179

fbshipit-source-id: c63eab65d79dc3bba081f6c6cd3f1a0b625d243a
@houseroad houseroad mentioned this pull request Feb 16, 2019
Closed
@houseroad houseroad mentioned this pull request Feb 19, 2019
Closed
houseroad added a commit to houseroad/pytorch that referenced this pull request Feb 19, 2019
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to 4c091e048ca42682d63ccd3c1811560bc1…
7434b62 
…2b732d (pytorch#17264)

Summary:
Pull Request resolved: pytorch#17264

Previous import was 822d8df0a2a32233c6022f50a158817a0f19bdc7

Included changes:
- **[4c091e0](onnx/onnx@4c091e0)**: Support defined ONNX_ML in parent cmake files (pytorch#1821) <Lu Fang>
- **[57372f3](onnx/onnx@57372f3)**: Delete OpsetVersionConverter.md which is a duplicate of VersionConverter.md (pytorch#1818) <Prasanth Pulavarthi>
- **[ab1c57e](onnx/onnx@ab1c57e)**: [ONNXIFI]Add extension to be implementable (pytorch#1796) <Rui Zhu>
- **[b92eee8](onnx/onnx@b92eee8)**: Revert "Implement Op Annotation's for ONNX (pytorch#1648)" (pytorch#1812) <Ke Zhang>
- **[61f1e9e](onnx/onnx@61f1e9e)**: Enable ONNX_ML by default (pytorch#1810) <Shinichiro Hamaji>
- **[4f064a1](onnx/onnx@4f064a1)**: fix Greater and Less doc (pytorch#1811) <Guoliang Hua>
- **[0628582](onnx/onnx@0628582)**: Implement Op Annotation's for ONNX (pytorch#1648) <Armen>
- **[ad9d2f7](onnx/onnx@ad9d2f7)**: Versioning doc update for Opset 9 (pytorch#1805) <Vinitra Swamy>
- **[e71e3be](onnx/onnx@e71e3be)**: add dilation case for ConvTranspose op (pytorch#1797) <Randy>

Differential Revision: D14135024

fbshipit-source-id: 9ee7d39a5efea5d9b3c12ac3e6acc32ae83c1d0e
ezyang pushed a commit to ezyang/pytorch that referenced this pull request Feb 19, 2019
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to 4c091e048ca42682d63ccd3c1811560bc1…
d73e6cb 
…2b732d (pytorch#17264)

Summary:
Pull Request resolved: pytorch#17264

Previous import was 822d8df0a2a32233c6022f50a158817a0f19bdc7

Included changes:
- **[4c091e0](onnx/onnx@4c091e0)**: Support defined ONNX_ML in parent cmake files (pytorch#1821) <Lu Fang>
- **[57372f3](onnx/onnx@57372f3)**: Delete OpsetVersionConverter.md which is a duplicate of VersionConverter.md (pytorch#1818) <Prasanth Pulavarthi>
- **[ab1c57e](onnx/onnx@ab1c57e)**: [ONNXIFI]Add extension to be implementable (pytorch#1796) <Rui Zhu>
- **[b92eee8](onnx/onnx@b92eee8)**: Revert "Implement Op Annotation's for ONNX (pytorch#1648)" (pytorch#1812) <Ke Zhang>
- **[61f1e9e](onnx/onnx@61f1e9e)**: Enable ONNX_ML by default (pytorch#1810) <Shinichiro Hamaji>
- **[4f064a1](onnx/onnx@4f064a1)**: fix Greater and Less doc (pytorch#1811) <Guoliang Hua>
- **[0628582](onnx/onnx@0628582)**: Implement Op Annotation's for ONNX (pytorch#1648) <Armen>
- **[ad9d2f7](onnx/onnx@ad9d2f7)**: Versioning doc update for Opset 9 (pytorch#1805) <Vinitra Swamy>
- **[e71e3be](onnx/onnx@e71e3be)**: add dilation case for ConvTranspose op (pytorch#1797) <Randy>

Reviewed By: yinghai

Differential Revision: D14135024

fbshipit-source-id: 1e4f9dda89abf48994798d080dd5d58207a6e4b6
zasdfgbnm added a commit that referenced this pull request May 4, 2022
@zasdfgbnm
nit cleanup in lower_loops.cpp (#1648)
b6593d4
akashveramd pushed a commit to akashveramd/pytorch that referenced this pull request Apr 9, 2025
@illsilin
restore collecting performance of mixed prec gemms (pytorch#1648)
5fb150d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @ezyang @soumith