Remove outdated FBGEMM check in CMake by cyyever · Pull Request #163952 · pytorch/pytorch

cyyever · 2025-09-26T12:33:55Z

FBGEMM can check 32 bit systems itself.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @aditew01

pytorch-bot · 2025-09-26T12:34:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163952

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/ec2-user/actions-runner/_work/pytorch/pytorch/.github/actions/check-tpu'

❌ 5 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit 5f71f58 with merge base e1eb3ce ():

NEW FAILURES - The following jobs have failed:

trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh)
test/test_nn.py::TestNN::test_fb_fc_packed
trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh)
test/inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_quantized_linear_cpu
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh)
test/test_linalg.py::TestLinalgCPU::test_svd_lowrank_cpu_complex128
trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-14) (gh)
test/test_nn.py::TestNN::test_fb_fc_packed
trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) (gh)
test/test_nn.py::TestNN::test_fb_fc_packed

CANCELLED JOB - The following job was cancelled. Please retry:

Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-jammy-py3.10-clang12 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) (gh) (trunk failure)
test/test_nn.py::TestNN::test_RNN_cell_forward_zero_hidden_size
pull / linux-jammy-py3.14-clang12 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) (gh) (trunk failure)
test/test_nn.py::TestNN::test_RNN_cell_forward_zero_hidden_size

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet · 2025-09-26T14:46:41Z

@pytorchbot merge

pytorchmergebot · 2025-09-26T14:49:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-26T14:55:22Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

cyyever · 2025-10-18T10:07:45Z

@pytorchmergebot merge

pytorchmergebot · 2025-10-18T10:09:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-18T10:20:32Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

cyyever · 2025-11-24T07:24:30Z

@pytorchbot rebase

pytorchmergebot · 2025-11-24T07:25:59Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-11-24T07:26:02Z

Successfully rebased fbgemm_check onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fbgemm_check && git pull --rebase)

Signed-off-by: Yuanyuan Chen <[email protected]>

github-actions · 2026-02-11T08:47:55Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2025

cyyever requested a review from q10 September 26, 2025 12:34

pytorchbot added the open source label Sep 26, 2025

malfet approved these changes Sep 26, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2025

malfet added release notes: build release notes category topic: improvements topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels Sep 26, 2025

pytorchmergebot added the merging label Sep 26, 2025

pytorchmergebot removed the merging label Sep 26, 2025

cyyever marked this pull request as draft September 30, 2025 06:16

cyyever added the ciflow/linux-aarch64 linux aarch64 CI workflow label Sep 30, 2025

cyyever force-pushed the fbgemm_check branch 3 times, most recently from 1db5b94 to 05632d5 Compare October 3, 2025 03:42

pytorch-bot bot added module: cpu CPU specific problem (e.g., perf, algorithm) release notes: quantization release notes category labels Oct 3, 2025

cyyever force-pushed the fbgemm_check branch 2 times, most recently from c4d4cec to ac257bc Compare October 3, 2025 04:23

cyyever force-pushed the fbgemm_check branch from ac257bc to 0cde9d2 Compare October 18, 2025 05:18

cyyever marked this pull request as ready for review October 18, 2025 05:40

cyyever requested review from digantdesai, jerryzh168, jianyuh, kimishpatel and salilsdesai as code owners October 18, 2025 05:40

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2025

pytorchmergebot added the merging label Oct 18, 2025

pytorchmergebot removed the merging label Oct 18, 2025

cyyever force-pushed the fbgemm_check branch from 0265ca0 to ebbf54d Compare October 18, 2025 11:01

cyyever marked this pull request as draft October 18, 2025 11:08

pytorchmergebot force-pushed the fbgemm_check branch from ebbf54d to 31fed7f Compare November 24, 2025 07:26

pytorch-bot bot added ciflow/b200 ciflow/h100 ciflow/rocm Trigger "default" config CI on ROCm labels Nov 24, 2025

cyyever force-pushed the fbgemm_check branch 3 times, most recently from 13e991f to ec81542 Compare December 8, 2025 23:37

huydhn mentioned this pull request Dec 10, 2025

[aarch64][caffe2] Fix FBGEMM detection on aarch64 #169379

Closed

cyyever force-pushed the fbgemm_check branch 5 times, most recently from 1ba6fe3 to ab743cb Compare December 12, 2025 14:09

cyyever added 2 commits December 13, 2025 09:47

Enable fbgemm on MPS

b50783a

Signed-off-by: Yuanyuan Chen <[email protected]>

Apple fixes

5f71f58

Signed-off-by: Yuanyuan Chen <[email protected]>

cyyever force-pushed the fbgemm_check branch from ab743cb to 5f71f58 Compare December 13, 2025 01:47

github-actions bot added the Stale label Feb 11, 2026

github-actions bot closed this Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove outdated FBGEMM check in CMake#163952

Remove outdated FBGEMM check in CMake#163952
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:fbgemm_check

cyyever commented Sep 26, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

malfet commented Sep 26, 2025

Uh oh!

pytorchmergebot commented Sep 26, 2025

Uh oh!

pytorchmergebot commented Sep 26, 2025

Uh oh!

cyyever commented Oct 18, 2025

Uh oh!

pytorchmergebot commented Oct 18, 2025

Uh oh!

pytorchmergebot commented Oct 18, 2025

Uh oh!

cyyever commented Nov 24, 2025

Uh oh!

pytorchmergebot commented Nov 24, 2025

Uh oh!

pytorchmergebot commented Nov 24, 2025

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cyyever commented Sep 26, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163952

❗ 1 Active SEVs

❌ 5 New Failures, 1 Cancelled Job, 2 Unrelated Failures

Uh oh!

malfet commented Sep 26, 2025

Uh oh!

pytorchmergebot commented Sep 26, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2025

Merge failed

Uh oh!

cyyever commented Oct 18, 2025

Uh oh!

pytorchmergebot commented Oct 18, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 18, 2025

Merge failed

Uh oh!

cyyever commented Nov 24, 2025

Uh oh!

pytorchmergebot commented Nov 24, 2025

Uh oh!

pytorchmergebot commented Nov 24, 2025

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cyyever commented Sep 26, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 26, 2025 •

edited

Loading