-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Compile] Fix Compile Warning for Capture Id #163898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compile] Fix Compile Warning for Capture Id #163898
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163898
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25ba328 with merge base ebfc87e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
```bash DEBUG /data/vllm-community-homes/vllm-user-6/pytorch/aten/src/ATen/cuda/CUDAGraph.h(59): warning pytorch#68-D: integer conversion resulted in a change of sign DEBUG CaptureId_t capture_id_ = -1; DEBUG ^ DEBUG DEBUG Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" DEBUG DEBUG /data/vllm-community-homes/vllm-user-6/pytorch/aten/src/ATen/cuda/CUDAGraph.h(59): warning pytorch#68-D: integer conversion resulted in a change of sign DEBUG CaptureId_t capture_id_ = -1; DEBUG ^ DEBUG DEBUG Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" DEBUG DEBUG /data/vllm-community-homes/vllm-user-6/pytorch/aten/src/ATen/cuda/CUDAGraph.h(59): warning pytorch#68-D: integer conversion resulted in a change of sign DEBUG CaptureId_t capture_id_ = -1; DEBUG ^ ``` Cuda won't use 0 as a capture id, so it is safe to initialize with 0, which also matches the initialization in `pytorch/aten/src/ATen/native/cudnn/RNN.cpp:2362` Pull Request resolved: pytorch#163898 Approved by: https://github.com/houseroad
Cuda won't use 0 as a capture id, so it is safe to initialize with 0, which also matches the initialization in
pytorch/aten/src/ATen/native/cudnn/RNN.cpp:2362