Skip to content

[ROCm][CI] adjust tf32 tolerance for test_compile_kernel_advanced #163783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethanwee1 wants to merge 1 commit into from
Closed

[ROCm][CI] adjust tf32 tolerance for test_compile_kernel_advanced #163783

ethanwee1 wants to merge 1 commit into from

Conversation

@ethanwee1
Copy link
Contributor

@ethanwee1 ethanwee1 commented Sep 24, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163783

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 36 Pending

As of commit 3c363e0 with merge base 4c2c401 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Sep 24, 2025
@jeffdaily jeffdaily marked this pull request as ready for review September 24, 2025 18:58
@jeffdaily
Copy link
Collaborator

jeffdaily commented Sep 24, 2025

@pytorchbot merge -f "rocm-only tolerance change, linter is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jeffdaily @jainapurva
[ROCm][CI] adjust tf32 tolerance for test_compile_kernel_advanced (#1…
53b2cf4 
…63783)

Fixes #ISSUE_NUMBER

Pull Request resolved: #163783
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <[email protected]>
@jithunnair-amd jithunnair-amd deleted the rocm_adjust_tf32_tol_test_compile_kernel_advanced branch October 28, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ethanwee1 @jeffdaily @pytorchmergebot @pytorchbot