[Inductor] Update DeviceAssert op to behave like store #163696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163696
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 21310b2 with merge base df4ebdd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mlazos
reviewed
Sep 24, 2025
torch/_inductor/codegen/common.py
Outdated
| raise NotImplementedError | ||
|
|
||
| def device_assert_async(self, cond: CSEVariable, msg: str) -> None: | ||
| raise NotImplementedError |
Contributor
There was a problem hiding this comment.
nit: make this have a message like the other one?
Collaborator
Author
There was a problem hiding this comment.
thanks, I've added the similar message.
mlazos
reviewed
Sep 24, 2025
torch/_inductor/ops_handler.py
Outdated
| return val | ||
|
|
||
| def device_assert_async(self, *args, **kwargs) -> None: | ||
| raise NotImplementedError("device_assert_async not implemented") |
Contributor
There was a problem hiding this comment.
similar comment, message consistency?
Collaborator
Author
There was a problem hiding this comment.
I've updated it.
Updated the DeviceAssert operation to match the behavior of Store, it will fixes the issue mentioned in [this PR](#163023) and updated testcases as Elias [suggested](#160677 (comment)). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben mlazos choijon5 [ghstack-poisoned]
mlazos
approved these changes
Sep 24, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Updated the DeviceAssert operation to match the behavior of Store, it will fixes the issue mentioned in [this PR](#163023) and updated testcases as Elias [suggested](#160677 (comment)). Pull Request resolved: #163696 Approved by: https://github.com/mlazos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Updated the DeviceAssert operation to match the behavior of Store, it will fixes the issue mentioned in this PR and updated testcases as Elias suggested.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos @choijon5