Skip to content

[Code Clean] Remove deadcodes about Python3.9 [1/N] #163626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fffrog wants to merge 2 commits into from
Closed

[Code Clean] Remove deadcodes about Python3.9 [1/N] #163626

fffrog wants to merge 2 commits into from

Conversation

@fffrog
Copy link
Collaborator

@fffrog fffrog commented Sep 23, 2025 •
edited
Loading

@fffrog
Update
9b60620 
[ghstack-poisoned]
@fffrog fffrog requested review from a team and jeffdaily as code owners September 23, 2025 08:43
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163626

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 95d172b with merge base d746b98 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 23, 2025
fffrog added a commit that referenced this pull request Sep 23, 2025
@fffrog
[Code Clean] Remove codes snippet about Python3.9
96ecc67 
As the title stated.


ghstack-source-id: ab19144
Pull-Request: #163626
This was referenced Sep 23, 2025
Closed
Closed
@fffrog fffrog requested a review from albanD September 23, 2025 11:40
@fffrog fffrog changed the title [Code Clean] Remove codes snippet about Python3.9 [Code Clean] Remove deadcodes about Python3.9 [1/N] Sep 23, 2025
This was referenced Sep 23, 2025
Closed
Closed
Closed
Closed
@albanD
Copy link
Collaborator

albanD commented Sep 23, 2025

Thanks for looking into this!
Confirming on the side with @atalman and @malfet that 3.9 is fully removed from everywhere before we break it and then we can go ahead and merge all of this!

@fffrog fffrog requested review from Skylion007 and ezyang September 23, 2025 15:01
albanD
albanD approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fffrog fffrog added the topic: not user facing topic category label Sep 24, 2025
@fffrog
Update
95d172b 
[ghstack-poisoned]
@fffrog fffrog mentioned this pull request Sep 24, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Starting merge as part of PR stack under #163646

pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [2/N] (#163627)
0bca779 
As the title stated.
Pull Request resolved: #163627
Approved by: https://github.com/jansel
ghstack dependencies: #163626
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [3/N] (#163629)
33aabdd 
As the title stated.
Pull Request resolved: #163629
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [4/N] (#163643)
ec0cd81 
As the title stated.
Pull Request resolved: #163643
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [5/N] (#163644)
6f34cc0 
As the title stated.
Pull Request resolved: #163644
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [6/N] (#163645)
a635505 
As the title stated.
Pull Request resolved: #163645
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629, #163643, #163644
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [7/N] (#163646)
2390d34 
As the title stated.

Pull Request resolved: #163646
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645
pytorchmergebot pushed a commit that referenced this pull request Sep 25, 2025
@fffrog @pytorchmergebot
[Code Clean] Remove deadcodes about Python3.9 [8/N] (#163728)
a213848 
As the title stated.

Pull Request resolved: #163728
Approved by: https://github.com/albanD, https://github.com/cyyever
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645, #163646
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [1/N] (pytorch#163626)
799f576 
As the title stated.
Pull Request resolved: pytorch#163626
Approved by: https://github.com/Skylion007, https://github.com/albanD
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [2/N] (pytorch#163627)
28280f1 
As the title stated.
Pull Request resolved: pytorch#163627
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#163626
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [3/N] (pytorch#163629)
3cbe00a 
As the title stated.
Pull Request resolved: pytorch#163629
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [4/N] (pytorch#163643)
e869ba2 
As the title stated.
Pull Request resolved: pytorch#163643
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [5/N] (pytorch#163644)
7fae4eb 
As the title stated.
Pull Request resolved: pytorch#163644
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [6/N] (pytorch#163645)
6acffb8 
As the title stated.
Pull Request resolved: pytorch#163645
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643, pytorch#163644
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fffrog @dsashidh
[Code Clean] Remove deadcodes about Python3.9 [7/N] (pytorch#163646)
920dcf5 
As the title stated.

Pull Request resolved: pytorch#163646
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#163626, pytorch#163627, pytorch#163629, pytorch#163643, pytorch#163644, pytorch#163645
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [1/N] (#163626)
54248f5 
As the title stated.
Pull Request resolved: #163626
Approved by: https://github.com/Skylion007, https://github.com/albanD
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [2/N] (#163627)
0f9e107 
As the title stated.
Pull Request resolved: #163627
Approved by: https://github.com/jansel
ghstack dependencies: #163626
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [3/N] (#163629)
81107b0 
As the title stated.
Pull Request resolved: #163629
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [4/N] (#163643)
cc9870d 
As the title stated.
Pull Request resolved: #163643
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [5/N] (#163644)
5ab8bff 
As the title stated.
Pull Request resolved: #163644
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [6/N] (#163645)
7f13bcb 
As the title stated.
Pull Request resolved: #163645
Approved by: https://github.com/albanD
ghstack dependencies: #163626, #163627, #163629, #163643, #163644
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [7/N] (#163646)
d5205ae 
As the title stated.

Pull Request resolved: #163646
Approved by: https://github.com/jansel
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@fffrog @jainapurva
[Code Clean] Remove deadcodes about Python3.9 [8/N] (#163728)
2d5e586 
As the title stated.

Pull Request resolved: #163728
Approved by: https://github.com/albanD, https://github.com/cyyever
ghstack dependencies: #163626, #163627, #163629, #163643, #163644, #163645, #163646
@github-actions github-actions bot deleted the gh/fffrog/161/head branch October 25, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged open source release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fffrog @albanD @pytorchmergebot @Skylion007 @pytorchbot