Skip to content

[inductor] libdevice.sqrt => tl.sqrt_rn #163419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jansel wants to merge 5 commits into from
Closed

[inductor] libdevice.sqrt => tl.sqrt_rn #163419

jansel wants to merge 5 commits into from

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 20, 2025 •
edited
Loading

@jansel
Update
1a7694f 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163419

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 75230b2 with merge base 51152ef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 20, 2025
Closed
Closed
jansel added a commit that referenced this pull request Sep 20, 2025
@jansel
[inductor] libdevice.sqrt => tl.sqrt_rn
44bf100 
Fixes #163082


ghstack-source-id: fd45400
Pull-Request: #163419
This was referenced Sep 20, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@jansel jansel added the topic: not user facing topic category label Sep 20, 2025
This was referenced Sep 20, 2025
Closed
Closed
@jansel
Update
c601eba 
[ghstack-poisoned]
@jansel
Update
7a44901 
[ghstack-poisoned]
This was referenced Sep 22, 2025
Closed
Closed
Closed
@jansel
Update
723956d 
[ghstack-poisoned]
@jansel jansel added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 22, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Starting merge as part of PR stack under #163434

@jansel
Update
75230b2 
[ghstack-poisoned]
@jansel jansel mentioned this pull request Sep 22, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2025

Starting merge as part of PR stack under #163422

1 similar comment
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2025

Starting merge as part of PR stack under #163422

pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Freeze layouts in FlexAttention (#163434)
ed84e80 
Fixes #163300

Pull Request resolved: #163434
Approved by: https://github.com/drisspg
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Support out_dtype arg to matmul (#163393)
9c4d9f9 
Fixes #163275

Pull Request resolved: #163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[dynamo] Fix TorchFunctionMode handling with get_rng_state (#163412)
6ef7487 
Fixes #162624
Fixes #162586

Pull Request resolved: #163412
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Fix error from custom CUDA allocators (#163422)
49e7b2f 
Fixes #163257

Pull Request resolved: #163422
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix issue with scalar arg handling (#163481)
ca512af 
Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix bugs in emulate_precision_casts (#163520)
6fa9727 
Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix divmod error in decomp (#163482)
d746b98 
Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
Revert "[inductor] Fix issue with scalar arg handling" (#163737)
3e1b1a3 
This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] libdevice.sqrt => tl.sqrt_rn (pytorch#163419)
4c1969e 
Fixes pytorch#163082

Pull Request resolved: pytorch#163419
Approved by: https://github.com/Skylion007, https://github.com/mlazos
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Freeze layouts in FlexAttention (pytorch#163434)
1fc5e2b 
Fixes pytorch#163300

Pull Request resolved: pytorch#163434
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Support out_dtype arg to matmul (pytorch#163393)
642eee2 
Fixes pytorch#163275

Pull Request resolved: pytorch#163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[dynamo] Fix TorchFunctionMode handling with get_rng_state (pytorch#1…
2cbaddb 
…63412)

Fixes pytorch#162624
Fixes pytorch#162586

Pull Request resolved: pytorch#163412
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix error from custom CUDA allocators (pytorch#163422)
f3d9ff8 
Fixes pytorch#163257

Pull Request resolved: pytorch#163422
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix issue with scalar arg handling (pytorch#163481)
e8e41d6 
Fixes pytorch#163420

Pull Request resolved: pytorch#163481
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix bugs in emulate_precision_casts (pytorch#163520)
25d3d52 
Fixes pytorch#163449
Pull Request resolved: pytorch#163520
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix divmod error in decomp (pytorch#163482)
9a6a07f 
Fixes pytorch#163457

Pull Request resolved: pytorch#163482
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
Revert "[inductor] Fix issue with scalar arg handling" (pytorch#163737)
be4de28 
This reverts commit a8cd437.

See pytorch#163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: pytorch#163737
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520, pytorch#163482
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix issue with scalar arg handling (#163481)
7fcb471 
Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix bugs in emulate_precision_casts (#163520)
0b4ce81 
Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix divmod error in decomp (#163482)
f424a19 
Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
Revert "[inductor] Fix issue with scalar arg handling" (#163737)
cb2c05b 
This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482
@jianyizh jianyizh mentioned this pull request Oct 17, 2025
Closed
@github-actions github-actions bot deleted the gh/jansel/541/head branch October 24, 2025 02:09
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@jansel
[inductor] libdevice.sqrt => tl.sqrt_rn
a4d3d22 
Fixes #163082

ghstack-source-id: 54c5feb
Pull-Request: pytorch/pytorch#163419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mlazos mlazos mlazos approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jansel @pytorchmergebot @Skylion007 @mlazos