[inductor] Don't require_dense for grid_sampler_2d_backward #163415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jansel wants to merge 4 commits into gh/jansel/540/base from gh/jansel/540/head

Contributor

jansel commented Sep 20, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben


          Update

a116ea2

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels

pytorch-bot bot commented Sep 20, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163415

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 03dd448 with merge base 51152ef ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request


          [inductor] Don't require_dense for grid_sampler_2d_backward

dd29016

Fixes #163372


ghstack-source-id: dcf87e1
Pull-Request: #163415

This was referenced Sep 20, 2025

Better decomp for torch.eye #163386

Closed

[inductor] Support out_dtype arg to matmul #163393

Closed

[inductor] Fix bug where viewed outputs get padded #163398

Closed

[inductor] Fallback on strided complex add #163387

Closed

Fix prims.broadcast_in_dim functionalization #163377

Closed

[dynamo] Fix TorchFunctionMode handling with get_rng_state #163412

Closed

[inductor] Skip test_baddmm on XPU #163414

Closed

[inductor] libdevice.sqrt => tl.sqrt_rn #163419

Closed

jansel added the topic: not user facing label

Skylion007 approved these changes

View reviewed changes

This was referenced Sep 20, 2025

[inductor] Fix error from custom CUDA allocators #163422

Closed

[inductor] Freeze layouts in FlexAttention #163434

Closed

jansel added 2 commits

September 20, 2025 22:27


          Update

8f99ab2

[ghstack-poisoned]


          Update

aaaa038

[ghstack-poisoned]

This was referenced Sep 22, 2025

[inductor] Fix issue with scalar arg handling #163481

Closed

[inductor] Fix divmod error in decomp #163482

Closed

[inductor] Fix bugs in emulate_precision_casts #163520

Closed


          Update

03dd448

[ghstack-poisoned]

jansel added the ciflow/trunk label

Collaborator

pytorchmergebot commented Sep 22, 2025

Starting merge as part of PR stack under #163434

Contributor Author

jansel commented Sep 22, 2025

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

4fc271e

pytorchmergebot removed the merging label

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] libdevice.sqrt => tl.sqrt_rn (#163419)

518c320

Fixes #163082

Pull Request resolved: #163419
Approved by: https://github.com/Skylion007, https://github.com/mlazos
ghstack dependencies: #163386, #163398, #163387, #163414, #163415

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Freeze layouts in FlexAttention (#163434)

ed84e80

Fixes #163300

Pull Request resolved: #163434
Approved by: https://github.com/drisspg
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Support out_dtype arg to matmul (#163393)

9c4d9f9

Fixes #163275

Pull Request resolved: #163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434

pytorchmergebot pushed a commit that referenced this pull request


          [dynamo] Fix TorchFunctionMode handling with get_rng_state (#163412)

6ef7487

Fixes #162624
Fixes #162586

Pull Request resolved: #163412
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Fix error from custom CUDA allocators (#163422)

49e7b2f

Fixes #163257

Pull Request resolved: #163422
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Fix issue with scalar arg handling (#163481)

ca512af

Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Fix bugs in emulate_precision_casts (#163520)

6fa9727

Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Fix divmod error in decomp (#163482)

d746b98

Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520

pytorchmergebot pushed a commit that referenced this pull request


          Revert "[inductor] Fix issue with scalar arg handling" (#163737)

3e1b1a3

This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Don't require_dense for grid_sampler_2d_backward (pytorch#…

e038c4d

…163415)

Fixes pytorch#163372

Pull Request resolved: pytorch#163415
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] libdevice.sqrt => tl.sqrt_rn (pytorch#163419)

4c1969e

Fixes pytorch#163082

Pull Request resolved: pytorch#163419
Approved by: https://github.com/Skylion007, https://github.com/mlazos
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Freeze layouts in FlexAttention (pytorch#163434)

1fc5e2b

Fixes pytorch#163300

Pull Request resolved: pytorch#163434
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Support out_dtype arg to matmul (pytorch#163393)

642eee2

Fixes pytorch#163275

Pull Request resolved: pytorch#163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [dynamo] Fix TorchFunctionMode handling with get_rng_state (pytorch#1…

2cbaddb

…63412)

Fixes pytorch#162624
Fixes pytorch#162586

Pull Request resolved: pytorch#163412
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Fix error from custom CUDA allocators (pytorch#163422)

f3d9ff8

Fixes pytorch#163257

Pull Request resolved: pytorch#163422
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Fix issue with scalar arg handling (pytorch#163481)

e8e41d6

Fixes pytorch#163420

Pull Request resolved: pytorch#163481
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Fix bugs in emulate_precision_casts (pytorch#163520)

25d3d52

Fixes pytorch#163449
Pull Request resolved: pytorch#163520
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [inductor] Fix divmod error in decomp (pytorch#163482)

9a6a07f

Fixes pytorch#163457

Pull Request resolved: pytorch#163482
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          Revert "[inductor] Fix issue with scalar arg handling" (pytorch#163737)

be4de28

This reverts commit a8cd437.

See pytorch#163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: pytorch#163737
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520, pytorch#163482

jainapurva pushed a commit that referenced this pull request


          [inductor] Fix issue with scalar arg handling (#163481)

7fcb471

Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422

jainapurva pushed a commit that referenced this pull request


          [inductor] Fix bugs in emulate_precision_casts (#163520)

0b4ce81

Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481

jainapurva pushed a commit that referenced this pull request


          [inductor] Fix divmod error in decomp (#163482)

f424a19

Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520

jainapurva pushed a commit that referenced this pull request


          Revert "[inductor] Fix issue with scalar arg handling" (#163737)

cb2c05b

This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482

github-actions bot deleted the gh/jansel/540/head branch

October 23, 2025 02:14

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request


          [inductor] Don't require_dense for grid_sampler_2d_backward

03a3f00

Fixes #163372


ghstack-source-id: feead1f
Pull-Request: pytorch/pytorch#163415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Merged module: inductor topic: not user facing