[CUDA] revert PR 130472 #163379
Merged
[CUDA] revert PR 130472 #163379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change may also resolve #161789, though verification is still needed. PR #130472 would introduced the problem of freeing the same address without clean metadata. according to the below discussion, reverted it. Pull Request resolved: #162950 Approved by: https://github.com/ngimel, https://github.com/eqy, https://github.com/syed-ahmed (cherry picked from commit 4a160da)
This was referenced Sep 19, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163379
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 478afce with merge base 4840a1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
syed-ahmed
approved these changes
Sep 20, 2025
atalman
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change may also resolve #161789, though verification is still needed.
PR #130472 would introduced the problem of freeing the same address without clean metadata. according to the below discussion, reverted it.