Skip to content

update test_quantization tests to run weekly #163077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liangel-02 wants to merge 1 commit into from
Closed

update test_quantization tests to run weekly #163077

liangel-02 wants to merge 1 commit into from

Conversation

@liangel-02
Copy link
Contributor

@liangel-02 liangel-02 commented Sep 16, 2025

Fixes #162854

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163077

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 46eaea0 with merge base 6b231af (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 16, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2025

Warning: Unknown label ciflow/quantization-periodic.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/triton_binaries
  • ciflow/inductor
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-perf-test-nightly-rocm
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-cu126
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/periodic-rocm-mi300
  • ciflow/rocm
  • ciflow/rocm-mi300
  • ciflow/s390
  • ciflow/riscv64
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/vllm
  • ciflow/torchbench
  • ciflow/op-benchmark
  • ciflow/pull
  • ciflow/h100
  • ciflow/h100-distributed
  • ciflow/win-arm64
  • ciflow/h100-symm-mem
  • ciflow/h100-cutlass-backend

Please add the new label to .github/pytorch-probot.yml

@liangel-02 liangel-02 force-pushed the test_quantization branch 2 times, most recently from 891b1a4 to 5655a5d Compare September 16, 2025 17:32
clee2000
clee2000 reviewed Sep 16, 2025
View reviewed changes
clee2000
clee2000 reviewed Sep 16, 2025
View reviewed changes
@liangel-02 liangel-02 force-pushed the test_quantization branch 3 times, most recently from 9d2478f to 668dc3d Compare September 16, 2025 21:53
clee2000
clee2000 reviewed Sep 16, 2025
View reviewed changes
huydhn
huydhn reviewed Sep 17, 2025
View reviewed changes
huydhn
huydhn reviewed Sep 17, 2025
View reviewed changes
@liangel-02 liangel-02 force-pushed the test_quantization branch 6 times, most recently from 664723f to 642d497 Compare September 17, 2025 20:13
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 17, 2025
@liangel-02 liangel-02 force-pushed the test_quantization branch 7 times, most recently from a4ca57e to 11e2f71 Compare September 18, 2025 20:51
@liangel-02 liangel-02 marked this pull request as ready for review September 19, 2025 17:07
@liangel-02 liangel-02 requested review from a team and jerryzh168 as code owners September 19, 2025 17:07
@liangel-02 liangel-02 requested a review from huydhn September 19, 2025 17:07
jerryzh168
jerryzh168 reviewed Sep 19, 2025
View reviewed changes
jerryzh168
jerryzh168 reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll let @clee2000 or @huydhn to do the final stamp

@liangel-02 liangel-02 requested a review from clee2000 September 19, 2025 17:21
huydhn
huydhn reviewed Sep 19, 2025
View reviewed changes
huydhn
huydhn reviewed Sep 19, 2025
View reviewed changes
.github/workflows/quantization-periodic.yml Outdated
cuda-arch-list: '7.5 8.9'
test-matrix: |
{ include: [
{ config: "quantization", shard: 1, num_shards: 1, runner: "linux.g6.4xlarge.experimental.nvidia.gpu" },
Copy link
Contributor

@huydhn huydhn Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the prefix here (just FYI, this is for Meta to LF infra migration)

Suggested change
{ config: "quantization", shard: 1, num_shards: 1, runner: "linux.g6.4xlarge.experimental.nvidia.gpu" },
{ config: "quantization", shard: 1, num_shards: 1, runner: "${{ needs.get-label-type.outputs.label-type }}linux.g6.4xlarge.experimental.nvidia.gpu" },

Copy link
Contributor Author

@liangel-02 liangel-02 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was getting a linting error so i changed it to this ${{ needs.get-default-label-prefix.outputs.label-type }}?

huydhn
huydhn approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of minor comments on the new workflow, the rest LGTM!

huydhn
huydhn reviewed Sep 19, 2025
View reviewed changes
huydhn
huydhn requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#163077 (comment)

@huydhn
Copy link
Contributor

huydhn commented Sep 23, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor

huydhn commented Sep 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@liangel-02 @dsashidh
update test_quantization tests to run weekly (pytorch#163077)
53d9211 
Fixes pytorch#162854

Pull Request resolved: pytorch#163077
Approved by: https://github.com/huydhn
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@liangel-02 @jainapurva
update test_quantization tests to run weekly (#163077)
093765a 
Fixes #162854

Pull Request resolved: #163077
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the test_quantization branch October 25, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 left review comments

@huydhn huydhn huydhn approved these changes

@clee2000 clee2000 Awaiting requested review from clee2000

Assignees

No one assigned

Labels

ciflow/quantization-periodic ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: quantization release notes category release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move test_quantization tests to run weekly

6 participants

@liangel-02 @huydhn @pytorchmergebot @jerryzh168 @clee2000