Fix boxcox to return same result for same input in one batch #162772

Yuhta · 2025-09-11T23:43:22Z

Summary:
The SIMD path is using SLEEF version of pow which is slightly different from std::pow. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results.

Rollback Plan:

Differential Revision: D82265247

pytorch-bot · 2025-09-11T23:43:25Z

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @Yuhta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

linux-foundation-easycla · 2025-09-11T23:43:27Z

The committers listed above are authorized under a signed CLA.

✅ login: Yuhta / name: Jimmy Lu (a436877)

pytorch-bot · 2025-09-11T23:43:28Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162772

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a436877 with merge base 65d642d ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-09-11T23:43:34Z

@Yuhta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265247.

facebook-github-bot · 2025-09-12T17:56:05Z

@Yuhta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265247.

…ytorch#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use SLEEF version of `pow` for the trailing data as well to ensure consistency between results. Test Plan: ``` buck test koski/functions_contrib/df4ai/tests:box_cox_test -- SameInputSameOutput buck2 test fbcode//caffe2/caffe2/python/operator_test:batch_box_cox_test ``` Rollback Plan: Differential Revision: D82265247

Yuhta · 2025-09-12T19:15:17Z

@pytorchbot label "topic: not user facing"

swolchok

Review automatically exported from Phabricator review in Meta.

…ytorch#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results. Test Plan: ``` buck test koski/functions_contrib/df4ai/tests:box_cox_test -- SameInputSameOutput buck2 test fbcode//caffe2/caffe2/python/operator_test:batch_box_cox_test ``` Rollback Plan: Differential Revision: D82265247

facebook-github-bot · 2025-09-12T20:11:22Z

@Yuhta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82265247.

facebook-github-bot · 2025-09-13T03:50:18Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-09-13T03:52:01Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results. Rollback Plan: Differential Revision: D82265247 Pull Request resolved: pytorch#162772 Approved by: https://github.com/swolchok

facebook-github-bot · 2025-09-19T17:56:56Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

pytorchmergebot · 2025-09-19T17:58:20Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-09-19T17:58:32Z

@Yuhta your PR has been successfully reverted.

…162772)" This reverts commit 49d30f9. Reverted #162772 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#162772 (comment)))

facebook-github-bot · 2025-09-19T18:35:37Z

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

pytorchmergebot · 2025-09-19T18:37:47Z

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-19T18:38:05Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team

Raised by workflow job

wdvr · 2025-09-22T02:33:30Z

unlanded internally. @Yuhta please follow up on D82753931 and open a new PR if this needs to be relanded / re-exported

…#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results. Rollback Plan: Differential Revision: D82265247 Pull Request resolved: pytorch#162772 Approved by: https://github.com/swolchok

…ytorch#162772)" This reverts commit 49d30f9. Reverted pytorch#162772 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#162772 (comment)))

…#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results. Rollback Plan: Differential Revision: D82265247 Pull Request resolved: pytorch#162772 Approved by: https://github.com/swolchok

…ytorch#162772)" This reverts commit 49d30f9. Reverted pytorch#162772 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#162772 (comment)))

…#162772) Summary: The SIMD path is using SLEEF version of `pow` which is slightly different from `std::pow`. The fix is to use the same vectorized code (with partial load and store) for the trailing data as well to ensure consistency between results. Rollback Plan: Differential Revision: D82265247 Pull Request resolved: pytorch#162772 Approved by: https://github.com/swolchok

…ytorch#162772)" This reverts commit 49d30f9. Reverted pytorch#162772 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#162772 (comment)))

pytorch-bot bot added the caffe2 label Sep 11, 2025

facebook-github-bot added fb-exported meta-exported labels Sep 11, 2025

Yuhta force-pushed the export-D82265247 branch from 1c0f28a to 12c1e19 Compare September 12, 2025 17:55

pytorch-bot bot added the topic: not user facing topic category label Sep 12, 2025

swolchok suggested changes Sep 12, 2025

View reviewed changes

Yuhta force-pushed the export-D82265247 branch from 12c1e19 to a436877 Compare September 12, 2025 20:11

Yuhta changed the title ~~[koski] Fix boxcox to return same result for same input in one batch~~ Fix boxcox to return same result for same input in one batch Sep 12, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 12, 2025

swolchok approved these changes Sep 12, 2025

View reviewed changes

pytorchmergebot added the merging label Sep 13, 2025

pytorchmergebot closed this in 49d30f9 Sep 13, 2025

pytorchmergebot added Merged and removed merging labels Sep 13, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 19, 2025

pytorchmergebot reopened this Sep 19, 2025

pytorchmergebot added the merging label Sep 19, 2025

pytorchmergebot removed the merging label Sep 19, 2025

wdvr closed this Sep 22, 2025

Fix boxcox to return same result for same input in one batch #162772

Fix boxcox to return same result for same input in one batch #162772

Uh oh!

Conversation

Yuhta commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 11, 2025

Uh oh!

linux-foundation-easycla bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162772

✅ No Failures

Uh oh!

facebook-github-bot commented Sep 11, 2025

Uh oh!

facebook-github-bot commented Sep 12, 2025

Uh oh!

Yuhta commented Sep 12, 2025

Uh oh!

swolchok left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 12, 2025

Uh oh!

facebook-github-bot commented Sep 13, 2025

Uh oh!

pytorchmergebot commented Sep 13, 2025

Merge started

Uh oh!

facebook-github-bot commented Sep 19, 2025

Uh oh!

pytorchmergebot commented Sep 19, 2025

Uh oh!

pytorchmergebot commented Sep 19, 2025

Uh oh!

facebook-github-bot commented Sep 19, 2025

Uh oh!

pytorchmergebot commented Sep 19, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 19, 2025

Merge failed

Uh oh!

wdvr commented Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Yuhta commented Sep 11, 2025 •

edited

Loading

linux-foundation-easycla bot commented Sep 11, 2025 •

edited

Loading

pytorch-bot bot commented Sep 11, 2025 •

edited

Loading