[dynamo][guards] Do not consturct framelocals to dict on GlobalsGuardAccessor #162694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Accessor [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162694
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c7da208 with merge base d033d11 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 11, 2025
anijain2305
added
ciflow/trunk
williamwen42
approved these changes
Sep 11, 2025
Collaborator
|
Starting merge as part of PR stack under #162695 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…162695) Pull Request resolved: #162695 Approved by: https://github.com/williamwen42 ghstack dependencies: #162694
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…Accessor (pytorch#162694) Pull Request resolved: pytorch#162694 Approved by: https://github.com/williamwen42
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ytorch#162695) Pull Request resolved: pytorch#162695 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162694
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…Accessor (pytorch#162694) Pull Request resolved: pytorch#162694 Approved by: https://github.com/williamwen42
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162695) Pull Request resolved: pytorch#162695 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162694
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…Accessor (pytorch#162694) Pull Request resolved: pytorch#162694 Approved by: https://github.com/williamwen42
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162695) Pull Request resolved: pytorch#162695 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162694
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…Accessor (pytorch#162694) Pull Request resolved: pytorch#162694 Approved by: https://github.com/williamwen42
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ytorch#162695) Pull Request resolved: pytorch#162695 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#162694
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
…Accessor ghstack-source-id: 90fb14f Pull Request resolved: pytorch/pytorch#162694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela