-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[ROCm] Bump FBGEMM commit to avoid CK errors #162590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162590
Note: Links to docs will display an error until the docs builds have been completed. ❌ 15 New Failures, 2 Cancelled Jobs, 20 Unrelated FailuresAs of commit e4e727c with merge base c238820 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
313bcdc to
e4e727c
Compare
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pragupta is this PR ready for review? We would like to land this to unblock the CI. |
My bad, I didn't realize that. Sorry about that. So we have to wait for @pragupta to merge then is it? |
|
I can pytorchbot merge -f. No need to wait. But does that mess up your Meta-internal import? |
@jeffdaily I think it should be fine. |
|
@pytorchbot merge -f "CI passing except known unrelated binary build failure in ROCm" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "This breaks CUDA 13 builds" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit c9b80c4. Reverted #162590 on behalf of https://github.com/malfet due to This breaks CUDA 13 builds ([comment](#162590 (comment)))
|
@pragupta your PR has been successfully reverted. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#162590 Approved by: https://github.com/jeffdaily
This reverts commit c9b80c4. Reverted pytorch#162590 on behalf of https://github.com/malfet due to This breaks CUDA 13 builds ([comment](pytorch#162590 (comment)))
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#162590 Approved by: https://github.com/jeffdaily
This reverts commit c9b80c4. Reverted pytorch#162590 on behalf of https://github.com/malfet due to This breaks CUDA 13 builds ([comment](pytorch#162590 (comment)))
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#162590 Approved by: https://github.com/jeffdaily
This reverts commit c9b80c4. Reverted pytorch#162590 on behalf of https://github.com/malfet due to This breaks CUDA 13 builds ([comment](pytorch#162590 (comment)))
Trying to solve the following CK build errors:
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd