Skip to content

Conversation

@pragupta
Copy link
Collaborator

@pragupta pragupta commented Sep 10, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162590

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 2 Cancelled Jobs, 20 Unrelated Failures

As of commit e4e727c with merge base c238820 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 10, 2025
@jithunnair-amd jithunnair-amd added ciflow/trunk Trigger trunk jobs on your pull request ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 10, 2025
@jithunnair-amd jithunnair-amd changed the title Bump FBGEMM commit to avoid CK errors [ROCm] Bump FBGEMM commit to avoid CK errors Sep 12, 2025
@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Sep 12, 2025
@jithunnair-amd jithunnair-amd added the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Sep 12, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2025

To add the ciflow label ciflow/binaries_libtorch please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Sep 12, 2025
@jithunnair-amd jithunnair-amd added the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Sep 12, 2025
@jithunnair-amd
Copy link
Collaborator

@pragupta Can you please include the changes from my PR #162648 to see if narrowing down the compilation targets for FBGEMM GENAI to gfx942 helps avoid these errors?

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 17, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot removed ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 17, 2025
@jithunnair-amd jithunnair-amd added ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2025

To add the ciflow label ciflow/rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2025

To add the ciflow label ciflow/rocm-mi300 please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 17, 2025
@jithunnair-amd jithunnair-amd added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 17, 2025
@q10
Copy link
Contributor

q10 commented Sep 18, 2025

@pragupta is this PR ready for review? We would like to land this to unblock the CI.

jeffdaily
jeffdaily previously approved these changes Sep 18, 2025
@sampathvic
Copy link
Contributor

Sorry I meant to say I saw you imported. I wasn't sure if that prevented me from force merging.

My bad, I didn't realize that. Sorry about that. So we have to wait for @pragupta to merge then is it?

@jeffdaily
Copy link
Collaborator

I can pytorchbot merge -f. No need to wait. But does that mess up your Meta-internal import?

@sampathvic
Copy link
Contributor

I can pytorchbot merge -f. No need to wait. But does that mess up your Meta-internal import?

@jeffdaily I think it should be fine.

@jeffdaily
Copy link
Collaborator

@pytorchbot merge -f "CI passing except known unrelated binary build failure in ROCm"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Sep 19, 2025

@pytorchbot revert -m "This breaks CUDA 13 builds" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 19, 2025
@pytorchmergebot
Copy link
Collaborator

@pragupta your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 19, 2025
@pytorch-bot pytorch-bot bot dismissed jeffdaily’s stale review September 19, 2025 18:13

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Sep 19, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@cthi
Copy link
Contributor

cthi commented Sep 22, 2025

@pragupta I've bumped fbgemm in #163411, which should fix the cuda13 build issue, and also includes the CK fix you added in fbgemm.

@pragupta
Copy link
Collaborator Author

@cthi thank you! Since #163411 brings in newer fbgemm, this PR is no longer needed. Closing

@pragupta pragupta closed this Sep 22, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants