-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Optimize channel_stats_op #16243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize channel_stats_op #16243
Conversation
6a3deb6 to
3fd906b
Compare
|
About 2x faster than before on GPU |
3fd906b to
05e564b
Compare
05e564b to
b3de25f
Compare
b3de25f to
4af77a5
Compare
Summary: Pull Request resolved: pytorch#16243 Optimize channel_stats_op and add NHWC impl Differential Revision: D13775515 fbshipit-source-id: 011692f17734d1d0cc8fac58cbd0a8c4002ce803
4af77a5 to
54e2bea
Compare
54e2bea to
587675a
Compare
587675a to
83af33c
Compare
83af33c to
5346885
Compare
5346885 to
0ab8a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be NHWC?
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, looks good.
0ab8a1c to
a181e6a
Compare
a181e6a to
5631d23
Compare
5631d23 to
b9d5089
Compare
Summary: Pull Request resolved: pytorch#16243 Optimize channel_stats_op and add NHWC impl Reviewed By: takatosp1 Differential Revision: D13775515 fbshipit-source-id: 91298117056ed9d47bd2f842d8c17e694dcf6902
b9d5089 to
34d7b52
Compare
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* upstream/master: (87 commits) Make Variable::set_data non-const; cosmetic fixes. remove warning for upsample code (pytorch#17921) Optimize TileOp (pytorch#17290) Optimize channel_stats_op (pytorch#16243) enable shape inference for elementwise operators (pytorch#17885) Remove remaining test jit expects redux (pytorch#17924) Handle Scalars Better (pytorch#17875) Fixed a formatting issue in doc comments (pytorch#17505) Add nbytes, itemsize, element_size to at::Tensor. (pytorch#17810) Fix lint in test_distributions.py Fix lint in test_jit.py Fix lint errors in test_autograd Added a few extra python bindings to help with walking the IR graph from Python (pytorch#17822) kthvalue consistency with sort in the presence of NaN (pytorch#17824) Fix minor grammatical mistakes in torch/nn/modules/loss.py (pytorch#17892) Remove (almost all) TensorOptions from native_functions.yaml (pytorch#17385) Restore full Windows tests (pytorch#17102) Prevent VS2017 from emitting ambiguous symbol errors (second time) Fix windows test hang (pytorch#17778) torch.btrifact for tensors with greater than 3 dimensions (pytorch#14964) ...
Summary: Optimize channel_stats_op and add NHWC impl
Differential Revision: D13775515