Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Sep 8, 2025

Related to #162333
#159779

@atalman atalman requested a review from a team as a code owner September 8, 2025 22:06
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit edfc8d2 with merge base fecd968 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@tinglvv tinglvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix 👍 !

@tinglvv
Copy link
Collaborator

tinglvv commented Sep 8, 2025

Previous driver worked because min driver for CUDA 12 was >=525, for CUDA 13 we need >=580 - https://docs.nvidia.com/deploy/cuda-compatibility/minor-version-compatibility.html

@malfet
Copy link
Contributor

malfet commented Sep 8, 2025

@atalman if nvbugs numbers are public, do you mind sharing the issue here? As all API calls should have failed with InsufficientDriver error code

@atalman atalman added ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR topic: not user facing topic category labels Sep 8, 2025
@atalman
Copy link
Contributor Author

atalman commented Sep 9, 2025

@pytorchmergebot merge -f windows_driver_update

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@atalman
Copy link
Contributor Author

atalman commented Sep 9, 2025

@pytorchmergebot merge -f "all required tests are passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Sep 9, 2025

@pytorchbot cherry-pick --onto release/2.9 --fixes "Critical CI fix" -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #162425

The cherry pick PR is at #162501 and it is linked with issue Critical CI fix. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman added a commit that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants