-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[CD][EZ] Update libtorch python version to 3.10 #162297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162297
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 18 PendingAs of commit 7ce730f with merge base 79fcd52 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Starting merge as part of PR stack under #162265 |
|
@pytorchbot merge -f "Is it really not mergeable?" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
|
Starting merge as part of PR stack under #162265 |
And raise error when building for an unsupported version Pull Request resolved: #162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: #162297
Not sure why it was at 3.9 Pull Request resolved: pytorch#162297 Approved by: https://github.com/clee2000, https://github.com/atalman
And raise error when building for an unsupported version Pull Request resolved: pytorch#162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162297
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension... Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS` Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5 TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025 Pull Request resolved: #162136 Approved by: https://github.com/atalman, https://github.com/huydhn ghstack dependencies: #162297, #162265
Not sure why it was at 3.9 Pull Request resolved: pytorch#162297 Approved by: https://github.com/clee2000, https://github.com/atalman
And raise error when building for an unsupported version Pull Request resolved: pytorch#162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162297
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension... Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS` Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5 TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025 Pull Request resolved: pytorch#162136 Approved by: https://github.com/atalman, https://github.com/huydhn ghstack dependencies: pytorch#162297, pytorch#162265
This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see #162297 ) sometimes in shell script (see #162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: #163339 Approved by: https://github.com/clee2000
Not sure why it was at 3.9 Pull Request resolved: pytorch#162297 Approved by: https://github.com/clee2000, https://github.com/atalman
And raise error when building for an unsupported version Pull Request resolved: pytorch#162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162297
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension... Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS` Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5 TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025 Pull Request resolved: pytorch#162136 Approved by: https://github.com/atalman, https://github.com/huydhn ghstack dependencies: pytorch#162297, pytorch#162265
This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see pytorch#162297 ) sometimes in shell script (see pytorch#162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: pytorch#163339 Approved by: https://github.com/clee2000
Not sure why it was at 3.9 Pull Request resolved: pytorch#162297 Approved by: https://github.com/clee2000, https://github.com/atalman
And raise error when building for an unsupported version Pull Request resolved: pytorch#162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162297
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension... Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS` Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5 TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025 Pull Request resolved: pytorch#162136 Approved by: https://github.com/atalman, https://github.com/huydhn ghstack dependencies: pytorch#162297, pytorch#162265
This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see pytorch#162297 ) sometimes in shell script (see pytorch#162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: pytorch#163339 Approved by: https://github.com/clee2000
This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see #162297 ) sometimes in shell script (see #162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: #163339 Approved by: https://github.com/clee2000 (cherry picked from commit 52dd7a8)
Move ROCM trunk wheel builds to 3.10 (#163339) This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see #162297 ) sometimes in shell script (see #162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: #163339 Approved by: https://github.com/clee2000 (cherry picked from commit 52dd7a8) Co-authored-by: Nikita Shulga <[email protected]>
Not sure why it was at 3.9 Pull Request resolved: pytorch#162297 Approved by: https://github.com/clee2000, https://github.com/atalman
And raise error when building for an unsupported version Pull Request resolved: pytorch#162265 Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162297
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension... Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS` Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5 TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025 Pull Request resolved: pytorch#162136 Approved by: https://github.com/atalman, https://github.com/huydhn ghstack dependencies: pytorch#162297, pytorch#162265
This code is a delicious spaghetti: Sometimes python version is defined in jinja template (see pytorch#162297 ) sometimes in shell script (see pytorch#162877 ), but this time around it's in a python file (and there is another one called `generate_binary_build_matrix.py` that defines `FULL_PYTHON_VERSIONS`) Pull Request resolved: pytorch#163339 Approved by: https://github.com/clee2000
Stack from ghstack (oldest at bottom):
setup-pythonaction #162136Not sure why it was at 3.9