[inductor][choices] rename get_mm_configs to get_template_configs #162293

coconutruben · 2025-09-05T20:03:26Z

Stack from ghstack (oldest at bottom):

why

eventually we want all templates to go through this
we're exposing this through diode as a sort of interface/API
avoid later renaming

what

rename get_mm_configs to get_template_configs
rename _finalize_mm_configs to _finalize_template_configs

testing

lintrunner
ci

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

Differential Revision: D81820641

\# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci [ghstack-poisoned]

pytorch-bot · 2025-09-05T20:03:29Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162293

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed46785 with merge base 468c1f9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

coconutruben · 2025-09-05T22:18:44Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

coconutruben · 2025-09-05T22:21:39Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

coconutruben · 2025-09-05T22:23:59Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]

coconutruben · 2025-09-05T22:31:32Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]

coconutruben · 2025-09-09T16:13:08Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…configs" \# why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming \# what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs \# testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]

coconutruben · 2025-09-10T18:01:34Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@coconutruben

…figs (#162293)" This reverts commit 30191fc. Reverted #162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](#161351 (comment)))

pytorchmergebot · 2025-09-11T20:24:21Z

@coconutruben your PR has been reverted as part of the stack under #161351.

…configs" # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) [ghstack-poisoned]

coconutruben · 2025-09-11T22:52:58Z

@coconutruben has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorchmergebot · 2025-09-12T21:04:45Z

Starting merge as part of PR stack under #161468

# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: #161468 Approved by: https://github.com/eellison ghstack dependencies: #161351, #161350, #162293

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

@coconutruben

…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

@coconutruben

…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

@coconutruben

…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

@coconutruben

…figs (pytorch#162293)" This reverts commit 30191fc. Reverted pytorch#162293 on behalf of https://github.com/huydhn due to Check with @coconutruben and the internal failures look real ([comment](pytorch#161351 (comment)))

…torch#162293) # why - eventually we want all templates to go through this - we're exposing this through diode as a sort of interface/API - avoid later renaming # what - rename get_mm_configs to get_template_configs - rename _finalize_mm_configs to _finalize_template_configs # testing - lintrunner - ci Differential Revision: [D81820641](https://our.internmc.facebook.com/intern/diff/D81820641) Pull Request resolved: pytorch#162293 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350

# why enable caching/overriding/filtering based on src hash later # what - KernelTemplate has a src_hash that is None by default - sha256 on TritonTemplate of the template src code - None on ExternKernelChoice to have same API # testing n/a (not in use in this change) Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D81821149](https://our.internmc.facebook.com/intern/diff/D81821149) Pull Request resolved: pytorch#161468 Approved by: https://github.com/eellison ghstack dependencies: pytorch#161351, pytorch#161350, pytorch#162293

coconutruben mentioned this pull request Sep 5, 2025

[inductor] V.choices.get_mm_configs override point #161349

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels Sep 5, 2025

coconutruben requested a review from eellison September 5, 2025 20:03

coconutruben added the topic: not user facing topic category label Sep 5, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2025

eellison approved these changes Sep 5, 2025

View reviewed changes

This was referenced Sep 9, 2025

[inductor] add kernel template choice (ktc) #161347

Closed

[inductor][ez] V.choices.get_mm_configs returns list of ChoiceCallers #161348

Closed

coconutruben added 3 commits September 9, 2025 11:09

pytorchmergebot closed this in 30191fc Sep 10, 2025

pytorchmergebot removed the merging label Sep 10, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 11, 2025

pytorchmergebot reopened this Sep 11, 2025

pytorchmergebot closed this in 269c990 Sep 12, 2025

github-actions bot deleted the gh/coconutruben/66/head branch October 13, 2025 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[inductor][choices] rename get_mm_configs to get_template_configs #162293

[inductor][choices] rename get_mm_configs to get_template_configs #162293

Uh oh!

coconutruben commented Sep 5, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 5, 2025 •

edited

Loading

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 9, 2025

Uh oh!

coconutruben commented Sep 10, 2025

Uh oh!

pytorchmergebot commented Sep 11, 2025

Uh oh!

coconutruben commented Sep 11, 2025

Uh oh!

pytorchmergebot commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[inductor][choices] rename get_mm_configs to get_template_configs #162293

[inductor][choices] rename get_mm_configs to get_template_configs #162293

Uh oh!

Conversation

coconutruben commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

why

what

testing

Uh oh!

pytorch-bot bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162293

✅ No Failures

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 5, 2025

Uh oh!

coconutruben commented Sep 9, 2025

Uh oh!

coconutruben commented Sep 10, 2025

Uh oh!

pytorchmergebot commented Sep 11, 2025

Uh oh!

coconutruben commented Sep 11, 2025

Uh oh!

pytorchmergebot commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coconutruben commented Sep 5, 2025 •

edited

Loading

pytorch-bot bot commented Sep 5, 2025 •

edited

Loading