Skip to content

[inductor] require shape in TritonCSEVariable #162275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isuruf wants to merge 14 commits into from
Closed

[inductor] require shape in TritonCSEVariable #162275

isuruf wants to merge 14 commits into from

Conversation

@isuruf
Copy link
Collaborator

@isuruf isuruf commented Sep 5, 2025 •
edited by pytorch-bot bot
Loading

@isuruf
Update
cf25e88 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162275

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 77ad1a3 with merge base c6ae757 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

isuruf added a commit that referenced this pull request Sep 5, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
389fdbb 
ghstack-source-id: 91e7141
Pull Request resolved: #162275
@isuruf
Update
f0386d1 
[ghstack-poisoned]
@isuruf isuruf mentioned this pull request Sep 8, 2025
Closed
isuruf added a commit that referenced this pull request Sep 8, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
6159c4c 
ghstack-source-id: df17942
Pull Request resolved: #162275
@isuruf
Update
5a481ea 
[ghstack-poisoned]
@isuruf isuruf mentioned this pull request Sep 9, 2025
Closed
isuruf added a commit that referenced this pull request Sep 9, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
1aa8c67 
ghstack-source-id: b4feffb
Pull Request resolved: #162275
@isuruf
Update
a96ff8e 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Sep 10, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
8c0c202 
ghstack-source-id: 5b7fa0f
Pull Request resolved: #162275
@isuruf
Update
d030cb7 
[ghstack-poisoned]
@isuruf isuruf mentioned this pull request Sep 11, 2025
Closed
isuruf added a commit that referenced this pull request Sep 11, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
a444d29 
ghstack-source-id: a724725
Pull Request resolved: #162275
@isuruf
Update
3da8dc6 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Sep 12, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
ea4bacd 
ghstack-source-id: 674fab2
Pull Request resolved: #162275
@isuruf
Copy link
Collaborator Author

isuruf commented Sep 15, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 15, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 15, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 15, 2025

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 1, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@isuruf
Update
2c6584f 
[ghstack-poisoned]
@isuruf isuruf mentioned this pull request Sep 15, 2025
Closed
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 15, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@izaitsevfb
Copy link
Contributor

izaitsevfb commented Nov 4, 2025

@pytorchmergebot revert -m "breaking test_rms_norm_bwd_float32_split_reductions_True_shape2" -c nosignal

test/inductor/test_mix_order_reduction.py::NoMixOrderReductionTest::test_rms_norm_bwd_float32_split_reductions_True_shape2 GH job link HUD commit link

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

@isuruf your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 4, 2025
@pytorchmergebot
Revert "[inductor] require shape in TritonCSEVariable (#162275)"
d3cf90a 
This reverts commit c21868b.

Reverted #162275 on behalf of https://github.com/izaitsevfb due to breaking test_rms_norm_bwd_float32_split_reductions_True_shape2 ([comment](#162275 (comment)))
@pytorch-auto-revert pytorch-auto-revert bot mentioned this pull request Nov 4, 2025
Open
pytorch-bot bot pushed a commit that referenced this pull request Nov 4, 2025
@isuruf @etaf
[inductor] require shape in TritonCSEVariable (#162275)
febb9a9 
Pull Request resolved: #162275
Approved by: https://github.com/mlazos
ghstack dependencies: #164158
pytorch-bot bot pushed a commit that referenced this pull request Nov 4, 2025
@pytorchmergebot @etaf
Revert "[inductor] require shape in TritonCSEVariable (#162275)"
7b6efef 
This reverts commit c21868b.

Reverted #162275 on behalf of https://github.com/izaitsevfb due to breaking test_rms_norm_bwd_float32_split_reductions_True_shape2 ([comment](#162275 (comment)))
@eellison
Copy link
Contributor

eellison commented Dec 2, 2025

@pytorchbot rebase

@eellison
Copy link
Contributor

eellison commented Dec 2, 2025

@isuruf i fixed the internal error that caused revert previously. the only remaining blockers should just be on oss.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 2, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 2, 2025

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/19870349113

@isuruf
Update
2e5dceb 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Dec 2, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
da68b87 
ghstack-source-id: 68830fe
Pull Request resolved: #162275
@isuruf
Update
5252af4 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Dec 3, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
676a91e 
ghstack-source-id: 3e0a70f
Pull Request resolved: #162275
@isuruf
Update
bd7b563 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Dec 3, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
4371239 
ghstack-source-id: 16ae700
Pull Request resolved: #162275
@isuruf
Update
77ad1a3 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Dec 4, 2025
@isuruf
[inductor] require shape in TritonCSEVariable
4533c12 
ghstack-source-id: cdd8635
Pull Request resolved: #162275
@isuruf
Copy link
Collaborator Author

isuruf commented Dec 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
@isuruf
[inductor] require shape in TritonCSEVariable (pytorch#162275)
9e65ae4 
Pull Request resolved: pytorch#162275
Approved by: https://github.com/mlazos
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@isuruf @JacobSzwejbka
[inductor] require shape in TritonCSEVariable (#162275)
9683787 
Pull Request resolved: #162275
Approved by: https://github.com/mlazos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison left review comments

@mlazos mlazos mlazos approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@isuruf @pytorchmergebot @jeffdaily @yangw-dev @eellison @clee2000 @izaitsevfb @mlazos @pytorchbot