Skip to content

[CD][BE] Delete Python-3.9 case #162265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 5 commits into from
Closed

[CD][BE] Delete Python-3.9 case #162265

malfet wants to merge 5 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 5, 2025 •
edited
Loading

@malfet
[CD][BE] Delete Python-3.9 case
41e7c70 
And raise error when building for an unsupported version

[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner September 5, 2025 14:53
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162265

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 30 Pending

As of commit 795956d with merge base 79fcd52 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 5, 2025
Closed
Closed
Closed
Closed
ZainRizvi
ZainRizvi approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up task: Update our linters to use py 3.10 instead

@malfet
Update
a1e0ce8 
[ghstack-poisoned]
@malfet
Update
6653fd7 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Sep 5, 2025
Closed
@malfet
Update
d3ee64e 
[ghstack-poisoned]
@malfet malfet added topic: not user facing topic category ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR labels Sep 5, 2025
@malfet
Copy link
Contributor Author

malfet commented Sep 5, 2025

@pytorchbot merge -f "Looks fine"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 197725596acd9ecd2f614a01ebfcd8f55ba7e8a4 returned non-zero exit code 1

Auto-merging .github/workflows/generated-windows-binary-libtorch-debug-nightly.yml
CONFLICT (content): Merge conflict in .github/workflows/generated-windows-binary-libtorch-debug-nightly.yml
Auto-merging .github/workflows/generated-windows-binary-libtorch-release-nightly.yml
CONFLICT (content): Merge conflict in .github/workflows/generated-windows-binary-libtorch-release-nightly.yml
error: could not apply 197725596ac... [CD][EZ] Update libtorch python version to 3.10
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@malfet
Update
795956d 
[ghstack-poisoned]
@malfet
Copy link
Contributor Author

malfet commented Sep 5, 2025

@pytorchbot merge -f "Take two"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 5, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@malfet @daisyden
[CD][BE] Delete Python-3.9 case (pytorch#162265)
0ca454a 
And raise error when building for an unsupported version
Pull Request resolved: pytorch#162265
Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: pytorch#162297
pytorchmergebot pushed a commit that referenced this pull request Sep 12, 2025
@malfet @pytorchmergebot
[CD] Build Mac wheels using setup-python action (#162136)
84d8ec7 
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: #162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: #162297, #162265
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[CD][BE] Delete Python-3.9 case (pytorch#162265)
be7477a 
And raise error when building for an unsupported version
Pull Request resolved: pytorch#162265
Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: pytorch#162297
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[CD] Build Mac wheels using setup-python action (pytorch#162136)
0de41da 
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[CD][BE] Delete Python-3.9 case (pytorch#162265)
7e3c368 
And raise error when building for an unsupported version
Pull Request resolved: pytorch#162265
Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: pytorch#162297
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@malfet @mansiag05
[CD] Build Mac wheels using setup-python action (pytorch#162136)
f874e91 
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[CD][BE] Delete Python-3.9 case (pytorch#162265)
fed5d0f 
And raise error when building for an unsupported version
Pull Request resolved: pytorch#162265
Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: pytorch#162297
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@malfet @cleonard530
[CD] Build Mac wheels using setup-python action (pytorch#162136)
09cd476 
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[CD][BE] Delete Python-3.9 case (pytorch#162265)
15fa853 
And raise error when building for an unsupported version
Pull Request resolved: pytorch#162265
Approved by: https://github.com/clee2000, https://github.com/Skylion007, https://github.com/ZainRizvi
ghstack dependencies: pytorch#162297
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@malfet @dsashidh
[CD] Build Mac wheels using setup-python action (pytorch#162136)
148bebf 
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
@github-actions github-actions bot deleted the gh/malfet/510/head branch October 6, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@clee2000 clee2000 clee2000 approved these changes

Assignees

No one assigned

Labels

ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @Skylion007 @ZainRizvi @clee2000