Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 4, 2025

Stack from ghstack (oldest at bottom):

Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both _PYTHON_PLATFORM and --plat-name as well as ARCH_FLAGS

Suppressed actionlint warning on use of freethreaded flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when 3.14 is out in October 2025

@malfet malfet requested a review from a team as a code owner September 4, 2025 03:52
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162136

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1d01c65 with merge base 79fcd52 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Sep 4, 2025
ghstack-source-id: 9f8c6d0
Pull Request resolved: #162136
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 4, 2025
@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Sep 4, 2025
malfet added a commit that referenced this pull request Sep 4, 2025
ghstack-source-id: d16d8ca
Pull Request resolved: #162136
malfet added a commit that referenced this pull request Sep 4, 2025
ghstack-source-id: fdef442
Pull Request resolved: #162136
malfet added a commit that referenced this pull request Sep 4, 2025
ghstack-source-id: fc4f299
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 4, 2025
ghstack-source-id: 1ff094f
Pull Request resolved: #162136
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: e854fa7
Pull Request resolved: #162136
[ghstack-poisoned]
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: 7a85d07
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: 104d420
Pull Request resolved: #162136
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: 104d420
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 5, 2025
ghstack-source-id: 5c634df
Pull Request resolved: #162136
malfet added a commit that referenced this pull request Sep 8, 2025
ghstack-source-id: 2a53adf
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 8d309c5
Pull Request resolved: #162136
echo "Finished setup.py bdist_wheel at $(date)"

if [[ $package_type != 'libtorch' ]]; then
if [[ $package_type == 'libooootorch' ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, is this a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a way to make sure delocate is skipped

[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: dd65768
Pull Request resolved: #162136
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we only need to skip torch.compile test when doing 3.13t

[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 2b39068
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 6a4d7fe
Pull Request resolved: #162136
[ghstack-poisoned]
malfet added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 8909bcb
Pull Request resolved: #162136
@malfet malfet added the ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR label Sep 9, 2025
@malfet
Copy link
Contributor Author

malfet commented Sep 9, 2025

@pytorchot merge -f "Binary builds + lint are green"

@malfet
Copy link
Contributor Author

malfet commented Sep 12, 2025

@pytorchbot merge -f "All is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Biggest difference between both conda and homebrew CPython builds and one from python.org, is that later are universal binaries and they are always trying to build universal extension...

Workaround lots of universal binary build attempts by explicitly specifying both `_PYTHON_PLATFORM` and `--plat-name` as well as `ARCH_FLAGS`

Suppressed actionlint warning on use of `freethreaded` flag which is document in https://github.com/actions/setup-python/tree/v5

TODO: Remove lots of temporary workarounds when `3.14` is out in October 2025

Pull Request resolved: pytorch#162136
Approved by: https://github.com/atalman, https://github.com/huydhn
ghstack dependencies: pytorch#162297, pytorch#162265
@github-actions github-actions bot deleted the gh/malfet/507/head branch October 12, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants