Skip to content

[inductor] turn on loaf (for oss) by default #162030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shunting314 wants to merge 20 commits into from
Closed

[inductor] turn on loaf (for oss) by default #162030

shunting314 wants to merge 20 commits into from

Conversation

@shunting314
Copy link
Contributor

@shunting314 shunting314 commented Sep 3, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162030

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 51c6f30 with merge base 5e7be98 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

shunting314 added a commit that referenced this pull request Sep 3, 2025
@shunting314
[inductor] turn on loaf (for oss) by default
859cde5 
ghstack-source-id: 3f5dcbe
Pull Request resolved: #162030
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
f4a45bc 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
This was referenced Sep 3, 2025
Closed
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
500cf16 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 3, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
d482e62 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 4, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
cebcacd 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
1534fdc 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 4, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
7ff7941 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
e8bb946 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 5, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
231dfcf 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 5, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
c20d5eb 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
370cb6c 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
5b9ab1d 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 6, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
22562de 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 mentioned this pull request Sep 8, 2025
Closed
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
e4f4c17 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314 shunting314 added the topic: not user facing topic category label Sep 8, 2025
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
96c6777 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
9be0660 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
f182f10 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@shunting314
Copy link
Contributor Author

shunting314 commented Sep 12, 2025 •
edited
Loading

I did another round of experiments. To make the measurement more accurate, I rebase upon a commit of a night run.
Here is the new link

  • the only change is the compilation time regression is more than expected for TIMM. It's 5s rather than 2s.

I then apply the patch here that optimize the construction of sympy.Min/Max , and here is the link for dashboard

  • it shows the patch fixes the 2s compilation time regression for TB and 5 seconds regression for TIMM.

I'll wait for WeakDep fix (#162316) before landing this stack

@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
845f170 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request Sep 22, 2025
@shunting314
[inductor] turn on loaf (for oss) by default
1c0e94d 
ghstack-source-id: 7ec2146
Pull Request resolved: #162030
@shunting314
Copy link
Contributor Author

shunting314 commented Sep 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 22, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@shunting314
Update on "[inductor] turn on loaf (for oss) by default"
51c6f30 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request Sep 22, 2025
@shunting314
[inductor] turn on loaf (for oss) by default
0c21361 
ghstack-source-id: c38259d
Pull Request resolved: #162030
@shunting314
Copy link
Contributor Author

shunting314 commented Sep 23, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2025

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15), trunk / win-vs2022-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / win-vs2022-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 23, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@shunting314
Copy link
Contributor Author

shunting314 commented Sep 23, 2025

@pytorchbot merge -i

1 similar comment
@shunting314
Copy link
Contributor Author

shunting314 commented Sep 24, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15), trunk / win-vs2022-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / win-vs2022-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@shunting314 @dsashidh
[inductor] turn on loaf (for oss) by default (pytorch#162030)
d1e41ad 
Pull Request resolved: pytorch#162030
Approved by: https://github.com/eellison, https://github.com/jansel
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@shunting314 @jainapurva
[inductor] turn on loaf (for oss) by default (#162030)
bb8b05e 
Pull Request resolved: #162030
Approved by: https://github.com/eellison, https://github.com/jansel
@github-actions github-actions bot deleted the gh/shunting314/215/head branch October 25, 2025 02:12
@eqy eqy mentioned this pull request Oct 30, 2025
Closed
Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request Nov 17, 2025
@shunting314
[inductor] turn on loaf (for oss) by default
1b7b6d4 
ghstack-source-id: 79d91c2
Pull Request resolved: pytorch/pytorch#162030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shunting314 @pytorchmergebot @jansel @eellison