Skip to content

[CI] Fix decorator logic in common_mps #161814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

[CI] Fix decorator logic in common_mps #161814

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 29, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Always decorate for MPS device. This fixes regressions in sparse testing
that were introduced by #160839

@malfet
Update
a3b9e84 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161814

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures

As of commit a3b9e84 with merge base 93c5112 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Aug 29, 2025
@malfet
[CI] Fix decorator logic in common_mps
e8d442a 
Always decorate for MPS device. This fixes regressions in sparse testing
that were introduced by #160839

ghstack-source-id: 12cb236
Pull Request resolved: #161814
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category labels Aug 29, 2025
@malfet
Copy link
Contributor Author

malfet commented Aug 30, 2025

Merged this one into reopened #160839

@malfet malfet closed this Aug 30, 2025
@github-actions github-actions bot deleted the gh/malfet/502/head branch September 29, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @atalman