[ONNX] Remove unused logic from internal verification module #161449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161449
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 309a56e with merge base 378edb0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
release notes: onnx
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 82e23a0 Pull Request resolved: #161449
justinchuby
commented
Aug 25, 2025
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 82e23a0 Pull Request resolved: pytorch#161449
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 20b866e Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: e0c6693 Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 573a0a9 Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: b8eb1f7 Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 64b0124 Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: eff90e2 Pull Request resolved: #161449
justinchuby
added a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 1de47fe Pull Request resolved: #161449
justinchuby
added
module: onnx
justinchuby
added a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: b8accf2 Pull Request resolved: #161449
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: b8accf2 Pull Request resolved: pytorch#161449
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 8e5129e Pull Request resolved: pytorch#161449
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: d1cf6fc Pull Request resolved: pytorch#161449
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 4d8210f Pull Request resolved: pytorch#161449
xadupre
approved these changes
Aug 28, 2025
titaiwangms
approved these changes
Aug 28, 2025
Collaborator
titaiwangms
left a comment
titaiwangms
left a comment
There was a problem hiding this comment.
This is bc breaking.
Collaborator
Author
The first PR breaks BC. This PR does the clean up |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: fa72c2b Pull Request resolved: pytorch#161449
Collaborator
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
Starting merge as part of PR stack under #161546 |
Collaborator
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
Collaborator
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 2, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: #161546 Approved by: https://github.com/titaiwangms ghstack dependencies: #161323, #161449
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…#161449) Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…#161449) Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Justin Chu [email protected]
cc @titaiwangms