[ONNX] Refactor torchscript based exporter #161323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161323
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 153c848 with merge base 378edb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
justinchuby
added a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 0a2854e Pull Request resolved: #161323
justinchuby
added a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 1c4e008 Pull Request resolved: #161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 1c4e008 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 1c4e008 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 1c4e008 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 027c5bd Pull Request resolved: #161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added
topic: bc breaking
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 34a7ba7 Pull Request resolved: #161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 34a7ba7 Pull Request resolved: #161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 64d66f1 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 64d66f1 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added
the
keep-going
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 36ef09c Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
justinchuby
added
ciflow/trunk
Contributor
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xadupre
reviewed
Aug 28, 2025
titaiwangms
approved these changes
Aug 28, 2025
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Justin Chu <[email protected]> ghstack-source-id: 31e64f4 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <[email protected]>
Contributor
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
angelayi
approved these changes
Sep 2, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
Starting merge as part of PR stack under #161449 |
Collaborator
|
Starting merge as part of PR stack under #161546 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: #161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: #161323
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 2, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: #161546 Approved by: https://github.com/titaiwangms ghstack dependencies: #161323, #161449
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved. - Updated module paths in `torch/csrc/autograd/python_function.cpp` accordingly - Removed `check_onnx_broadcast` from `torch/autograd/_functions/utils.py` because it is private&unused @albanD / @soulitzer could you review changes in `torch/csrc/autograd/python_function.cpp` and `torch/autograd/_functions/utils.py`? Thanks! ## BC Breaking - **Deprecated members in `torch.onnx.verification` are removed** Differential Revision: [D81236421](https://our.internmc.facebook.com/intern/diff/D81236421) Pull Request resolved: pytorch#161323 Approved by: https://github.com/titaiwangms, https://github.com/angelayi
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…#161449) Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved. - Updated module paths in `torch/csrc/autograd/python_function.cpp` accordingly - Removed `check_onnx_broadcast` from `torch/autograd/_functions/utils.py` because it is private&unused @albanD / @soulitzer could you review changes in `torch/csrc/autograd/python_function.cpp` and `torch/autograd/_functions/utils.py`? Thanks! ## BC Breaking - **Deprecated members in `torch.onnx.verification` are removed** Differential Revision: [D81236421](https://our.internmc.facebook.com/intern/diff/D81236421) Pull Request resolved: pytorch#161323 Approved by: https://github.com/titaiwangms, https://github.com/angelayi
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…#161449) Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <[email protected]> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved.
torch/csrc/autograd/python_function.cppaccordinglycheck_onnx_broadcastfromtorch/autograd/_functions/utils.pybecause it is private&unused@albanD / @soulitzer could you review changes in
torch/csrc/autograd/python_function.cppandtorch/autograd/_functions/utils.py? Thanks!BC Breaking
torch.onnx.verificationare removedcc @titaiwangms @albanD
Differential Revision: D81236421