[dynamo] Remove extra if statement in builder _wrap #161215
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161215
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit fad538a with merge base 7006fd0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_dynamo/variables/builder.py
Outdated
| ): | ||
| # If it's either tensor or subclass with default torch_dispatch | ||
| # (they might override torch_function), we can always trace into them. | ||
| # For non-default torch_dispatch, we have more requirements. |
There was a problem hiding this comment.
While you are here, maybe remove this comment as well, it's confusing, it was meant to go before the is_traceable_wrapper_subclass(value) check, as that check encodes the "more requirements".
The comment above this basically elaborates on the type(value).__torch_dispatch__ is torch.Tensor.__torch_dispatch__ check.
There was a problem hiding this comment.
Sg, removed. Will merge after CI is green.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Removes a redundant if statement. Does not impact logic so no test changes needed. Pull Request resolved: pytorch#161215 Approved by: https://github.com/StrongerXi
3 participants
Removes a redundant if statement. Does not impact logic so no test changes needed.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @mlazos