[export] Remove unused Model, tensor_paths, constant_paths #161185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I used `--force-unsafe` to update the fields for `ExportedProgram`. This is theoretically a BC breaking change. But no one is consuming these fields. So it's safe to remove. Test Plan: buck2 run mode/dev-nosan caffe2:export_update_schema -- --prefix /data/users/yimingzhou/fbsource/fbcode/caffe2/ --force-unsafe And CI Rollback Plan: Differential Revision: D80725094
yiming0416
requested review from
SherlockNoMad,
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161185
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a6548c with merge base 9668210 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80725094 |
SherlockNoMad
approved these changes
Aug 21, 2025
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wincent8
pushed a commit
to wincent8/pytorch
that referenced
this pull request
Aug 22, 2025
…61185) Summary: Removed `Model`, it's not being used anywhere so it's safe. Removed `tensor_paths` and `constant_paths` fields in `ExportedProgram` - BC: when the current deserializer load a previously serialized EP (that comes with empty `tensor_paths` and `constant_paths`), it will just ignore those two fields - FC: when the old deserializer load a newly serialized EP (that doesn't come with `tensor_paths` and `constant_paths`, it will also ignore those two fields in `_dict_to_dataclass()` Differential Revision: D80725094 Pull Request resolved: pytorch#161185 Approved by: https://github.com/SherlockNoMad
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…61185) Summary: Removed `Model`, it's not being used anywhere so it's safe. Removed `tensor_paths` and `constant_paths` fields in `ExportedProgram` - BC: when the current deserializer load a previously serialized EP (that comes with empty `tensor_paths` and `constant_paths`), it will just ignore those two fields - FC: when the old deserializer load a newly serialized EP (that doesn't come with `tensor_paths` and `constant_paths`, it will also ignore those two fields in `_dict_to_dataclass()` Differential Revision: D80725094 Pull Request resolved: pytorch#161185 Approved by: https://github.com/SherlockNoMad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removed
Model, it's not being used anywhere so it's safe.Removed
tensor_pathsandconstant_pathsfields inExportedProgramtensor_pathsandconstant_paths), it will just ignore those two fieldstensor_pathsandconstant_paths, it will also ignore those two fields in_dict_to_dataclass()Differential Revision: D80725094