Skip to content

Refactoring TensorImpl by using constexpr and std::is_same_v #161043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fffrog wants to merge 2 commits into from
Closed

Refactoring TensorImpl by using constexpr and std::is_same_v #161043

fffrog wants to merge 2 commits into from

Conversation

@fffrog
Copy link
Collaborator

@fffrog fffrog commented Aug 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

As the title stated.

@fffrog
Update
0037299 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161043

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0aadd65 with merge base daeb3a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fffrog added a commit that referenced this pull request Aug 20, 2025
@fffrog
Refactoring TensorImpl by using constexpr and std::is_same_v
7b2e538 
As the title stated.


ghstack-source-id: 9152178
Pull-Request-resolved: #161043
@fffrog
Copy link
Collaborator Author

fffrog commented Aug 20, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 20, 2025
@fffrog
Update
0aadd65 
[ghstack-poisoned]
fffrog added a commit that referenced this pull request Aug 20, 2025
@fffrog
Refactoring TensorImpl by using constexpr and std::is_same_v
9095323 
As the title stated.

ghstack-source-id: 85a8887
Pull-Request-resolved: #161043
@fffrog fffrog requested review from Skylion007, albanD and ezyang August 20, 2025 06:49
@fffrog
Copy link
Collaborator Author

fffrog commented Aug 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 22, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fffrog
Copy link
Collaborator Author

fffrog commented Aug 22, 2025

@Skylion007 Thank you.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / build

Details for Dev Infra team Raised by workflow job

@fffrog
Copy link
Collaborator Author

fffrog commented Aug 22, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@fffrog @markc-614
Refactoring TensorImpl by using constexpr and std::is_same_v (pytorch…
1146c8d 
…#161043)

As the title stated.
Pull Request resolved: pytorch#161043
Approved by: https://github.com/Skylion007
@github-actions github-actions bot deleted the gh/fffrog/144/head branch September 22, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fffrog @pytorchmergebot @Skylion007 @pytorchbot