[MPS] sparse add unary funcs + add for sparse tensors #160839

Isalia20 · 2025-08-17T11:15:34Z

Adds several unary functions and add. Enables tests for unary functions in test_sparse but not enabling other tests yet, needs more ops before we fully migrate to testing SparseMPS with test_sparse.py

cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen

pytorch-bot · 2025-08-17T11:15:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160839

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm MI2xx CI/CD workflows failing due to : download from https://api.github.com/repos/pytorch/pytorch timed out.

⏳ 7 Pending, 1 Unrelated Failure

As of commit 52be981 with merge base d8a0bdb ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-14) (gh) (similar failure)
Build left local git repository checkout dirty

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-08-17T11:19:35Z

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

aten/src/ATen/native/native_functions.yaml

malfet

I haven't look much into the ops implementation, but testing look problematic.
Generally speaking avoid skipping the test, instead prefer fail.
Also, prefer adding decorators to their respective OpInfo definitions rather than test itself

malfet · 2025-08-17T14:10:18Z

test/test_mps.py

        self.assertEqual(coalesced_mps._indices().cpu(), coalesced_cpu._indices())
        self.assertEqual(coalesced_mps._values().cpu(), coalesced_cpu._values())

+    def test_sparse_add(self):


Can you please elaborate why this long test is needed and isn't it covered by test_sparse?

I enabled unary function tests on test_sparse so far, before I enable other tests, which need more work, I added a test here so we can have some testing functionality before we completely move to testing with test_sparse.py

If there are testing on test_sparse, let's just used those...

malfet · 2025-08-17T14:11:08Z

test/test_sparse.py

+MPS_UNSUPPORTED_TYPES = [torch.double, torch.cdouble]
+MPS_DTYPES = [t for t in get_all_dtypes() if t not in MPS_UNSUPPORTED_TYPES]


Do you mind moving this logic to common_mps and use from both test_mps and test_sparse_

Removed this completely

malfet · 2025-08-17T14:12:28Z

torch/testing/_internal/common_mps.py

+            "linalg.eig": None,
+            "linalg.eigvals": None,
+            "put": None,
+            # "conj_physical": None,


Oops, leftover, removed

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

Always decorate for MPS device. This fixes regressions in sparse testing that were introduced by #160839 ghstack-source-id: 12cb236 Pull Request resolved: #161814

torch/testing/_internal/common_mps.py

malfet · 2025-08-30T00:35:16Z

@pytorchbot merge -f "2nd time is the charm"

pytorchmergebot · 2025-08-30T00:36:55Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-08-30T00:37:05Z

Merge failed

Reason: PR #160839 has not been reviewed yet

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

malfet · 2025-08-30T01:07:00Z

@pytorchbot merge -f "Second time is the charm"

pytorchmergebot · 2025-08-30T01:08:34Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Adds several unary functions and add. Enables tests for unary functions in test_sparse but not enabling other tests yet, needs more ops before we fully migrate to testing SparseMPS with `test_sparse.py` Pull Request resolved: pytorch#160839 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <[email protected]>

…h#160839)" This reverts commit 93c5112. Reverted pytorch#160839 on behalf of https://github.com/atalman due to test_sparse_csr.py::TestSparseCompressedCPU::test_consistency_SparseCSR_asinh_cpu_complex64 [GH job link](https://github.com/pytorch/pytorch/actions/runs/17329155095/job/49201551217) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/93c5112f46a978a029644ae599979416ead5c917) ([comment](pytorch#160839 (comment)))

Adds several unary functions and add. Enables tests for unary functions in test_sparse but not enabling other tests yet, needs more ops before we fully migrate to testing SparseMPS with `test_sparse.py` Pull Request resolved: pytorch#160839 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <[email protected]>

…h#160839)" This reverts commit 93c5112. Reverted pytorch#160839 on behalf of https://github.com/atalman due to test_sparse_csr.py::TestSparseCompressedCPU::test_consistency_SparseCSR_asinh_cpu_complex64 [GH job link](https://github.com/pytorch/pytorch/actions/runs/17329155095/job/49201551217) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/93c5112f46a978a029644ae599979416ead5c917) ([comment](pytorch#160839 (comment)))

Adds several unary functions and add. Enables tests for unary functions in test_sparse but not enabling other tests yet, needs more ops before we fully migrate to testing SparseMPS with `test_sparse.py` Pull Request resolved: pytorch#160839 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <[email protected]>

Isalia20 added 4 commits August 9, 2025 01:37

enable indices and values on sparse mps

7be6762

working version

3798c17

tests

eb6588f

Merge branch 'main' into mps-sparse-add-unary-funcs

c4a072d

Isalia20 requested review from kulinseth and malfet as code owners August 17, 2025 11:15

pytorch-bot bot added the release notes: sparse release notes category label Aug 17, 2025

Isalia20 changed the title ~~[MPS] sparse add unary funcs~~ [MPS] sparse add unary funcs + add for sparse tensors Aug 17, 2025

Isalia20 added the module: mps Related to Apple Metal Performance Shaders framework label Aug 17, 2025

pytorchbot added the open source label Aug 17, 2025

redundancy

410de8d

Isalia20 added the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

linter

e4a6c25

pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

remove mps guard

95c0c36

Isalia20 added the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

better guard

33396a6

pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

malfet requested changes Aug 17, 2025

View reviewed changes

Isalia20 mentioned this pull request Aug 17, 2025

[MPS] index_add inconsistency on complex tensors #160845

Closed

cleanup

e30a547

Isalia20 added the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

sparse check grad modifier

a32a4a8

pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

sparse true

d740cd6

Isalia20 added the ciflow/mps Run MPS tests (subset of trunk) label Aug 17, 2025

return all types and complex back

906d0df

pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 18, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 29, 2025

pytorchmergebot reopened this Aug 29, 2025

malfet mentioned this pull request Aug 29, 2025

[CI] Fix decorator logic in common_mps #161814

Closed

malfet added a commit that referenced this pull request Aug 29, 2025

[CI] Fix decorator logic in common_mps

e8d442a

Always decorate for MPS device. This fixes regressions in sparse testing that were introduced by #160839 ghstack-source-id: 12cb236 Pull Request resolved: #161814

malfet reviewed Aug 29, 2025

View reviewed changes

Apply suggestions from code review

52be981

pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/mps Run MPS tests (subset of trunk) labels Aug 29, 2025

malfet added ciflow/trunk Trigger trunk jobs on your pull request ciflow/mps Run MPS tests (subset of trunk) labels Aug 29, 2025

pytorchmergebot added the merging label Aug 30, 2025

pytorchmergebot removed the merging label Aug 30, 2025

malfet approved these changes Aug 30, 2025

View reviewed changes

pytorchmergebot added the merging label Aug 30, 2025

pytorchmergebot closed this in 8627a19 Aug 30, 2025

pytorchmergebot removed the merging label Aug 30, 2025

		MPS_UNSUPPORTED_TYPES = [torch.double, torch.cdouble]
		MPS_DTYPES = [t for t in get_all_dtypes() if t not in MPS_UNSUPPORTED_TYPES]

[MPS] sparse add unary funcs + add for sparse tensors #160839

[MPS] sparse add unary funcs + add for sparse tensors #160839

Uh oh!

Conversation

Isalia20 commented Aug 17, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160839

❗ 1 Active SEVs

⏳ 7 Pending, 1 Unrelated Failure

Uh oh!

github-actions bot commented Aug 17, 2025

Attention! native_functions.yaml was changed

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

malfet Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Isalia20 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

malfet Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

malfet Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Isalia20 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

malfet Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Isalia20 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

malfet commented Aug 30, 2025

Uh oh!

pytorchmergebot commented Aug 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 30, 2025

Merge failed

Uh oh!

malfet commented Aug 30, 2025

Uh oh!

pytorchmergebot commented Aug 30, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Isalia20 commented Aug 17, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 17, 2025 •

edited

Loading