Skip to content

Decrease number of bytes used by uninitialized tokens_ in KernelFunction #160764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikaylagawarecki wants to merge 3 commits into from
Closed

Decrease number of bytes used by uninitialized tokens_ in KernelFunction #160764

mikaylagawarecki wants to merge 3 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 15, 2025 •
edited
Loading

std::unique_ptr to decrease bytes from 24 to 8

Since std::unique_ptr is not copyable this required defining the copy / copy assignment constructors. Which made me realize we shouldn't be copying tokens_ in those.

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160764

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b468461 with merge base a9fabeb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 15, 2025
@mikaylagawarecki
Decrease number of bytes used by uninitialized tokens_ in KernelFunction
cf7d7c4 
ghstack-source-id: 59095cd
Pull Request resolved: #160764
mikaylagawarecki added a commit that referenced this pull request Aug 15, 2025
@mikaylagawarecki
Decrease number of bytes used by uninitialized tokens_ in KernelFunction
b2746a9 
ghstack-source-id: 473ca1e
Pull Request resolved: #160764
mikaylagawarecki added a commit that referenced this pull request Aug 20, 2025
@mikaylagawarecki
Decrease number of bytes used by uninitialized tokens_ in KernelFunction
48d9a44 
ghstack-source-id: eb9cc5a
Pull Request resolved: #160764
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 20, 2025 15:30
albanD
albanD approved these changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 20, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 20, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 20, 2025

Merge failed

Reason: 3 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / build, trunk / linux-jammy-rocm-py3.10 / build, trunk / verify-cachebench-cpu-build / build

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 20, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pragupta added a commit to ROCm/pytorch that referenced this pull request Sep 16, 2025
@pragupta
Revert "Decrease number of bytes used by uninitialized tokens_ in Ker…
6c9c22c 
…nelFunction (pytorch#160764)"

This reverts commit 30384ab.
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mikaylagawarecki @markc-614
Decrease number of bytes used by uninitialized tokens_ in KernelFunct…
6c71d2b 
…ion (pytorch#160764)

std::unique_ptr to decrease bytes from 24 to 8

Since std::unique_ptr is not copyable this required defining the copy / copy assignment constructors. Which made me realize we shouldn't be copying `tokens_` in those.

Pull Request resolved: pytorch#160764
Approved by: https://github.com/albanD
pragupta added a commit to ROCm/pytorch that referenced this pull request Sep 17, 2025
@pragupta
Revert "Decrease number of bytes used by uninitialized tokens_ in Ker…
cd45fe7 
…nelFunction (pytorch#160764)"

This reverts commit 30384ab.
@github-actions github-actions bot deleted the gh/mikaylagawarecki/335/head branch September 20, 2025 02:06
pragupta added a commit to ROCm/pytorch that referenced this pull request Sep 24, 2025
@pragupta
Revert "Decrease number of bytes used by uninitialized tokens_ in Ker…
3004b5d 
…nelFunction (pytorch#160764)"

This reverts commit 30384ab.

(cherry picked from commit cd45fe7)
jataylo added a commit to jataylo/pytorch that referenced this pull request Oct 17, 2025
@jataylo
Revert "Decrease number of bytes used by uninitialized tokens_ in Ker…
a72d8f6 
…nelFunction (pytorch#160764)"

This reverts commit 30384ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikaylagawarecki @pytorchmergebot @albanD