Update transformers version automatically with Dependabot #160635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160635
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 51c3412 with merge base 838f22c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
release notes: releng
ZainRizvi
approved these changes
Aug 15, 2025
Contributor
ZainRizvi
left a comment
ZainRizvi
left a comment
There was a problem hiding this comment.
I like it. We should do this more often
Approved pending the file rename fix
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
huydhn
force-pushed
the
autoupdate-transformers-pin-via-pr
branch
from
c4cb900 to
fde6933
Compare
Signed-off-by: Huy Do <[email protected]>
Contributor
Author
|
@pytorchbot merge |
huydhn
added
test-config/default
and removed
ciflow/trunk
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 19, 2025
After #160635, I can see dependabot creating the PR to bump `transformers` version at #160807. This a good start, but there are several tweaks we need: 1. Run inductor tests on the PR including one round of perf benchmark, which is always needed. So, we need `ciflow/inductor` label and a `pull_request` trigger for the benchmark 2. Per @anijain2305 feedback, we don't need to update patch version. So, I add a rule to ignore it. Again, we would need to test this out after this lands. Pull Request resolved: #160935 Approved by: https://github.com/anijain2305
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
…0635) My proposal here is to use GitHub Dependabot to make sure that `transformers` version used in CI are always up-to-date. To achieve this, this PR does 2 things: 1. Pin `transformers` version across all CI jobs to only one place at `.ci/docker/ci_commit_pins/huggingface.txt`. This file is now a regular pip requirements instead of a pinned commit text. There isn't any need to pin `transformers` to a specific commit and the file already refers to a stable version `v4.54.0` 2. Create `.github/dependabot.yml` to config the bot to update `transformers` automatically when there is a new version. Those labels will ensure that the right reviewers from torch.compile and Dev Infra are notified. I'm not sure how to test this out in PR, but it feels ok to land and test this in main. If this works, we should see a PR to update `v4.54.0` to the current latest `v4.55.0` ### Reference https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference Pull Request resolved: pytorch#160635 Approved by: https://github.com/ZainRizvi
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…0635) My proposal here is to use GitHub Dependabot to make sure that `transformers` version used in CI are always up-to-date. To achieve this, this PR does 2 things: 1. Pin `transformers` version across all CI jobs to only one place at `.ci/docker/ci_commit_pins/huggingface.txt`. This file is now a regular pip requirements instead of a pinned commit text. There isn't any need to pin `transformers` to a specific commit and the file already refers to a stable version `v4.54.0` 2. Create `.github/dependabot.yml` to config the bot to update `transformers` automatically when there is a new version. Those labels will ensure that the right reviewers from torch.compile and Dev Infra are notified. I'm not sure how to test this out in PR, but it feels ok to land and test this in main. If this works, we should see a PR to update `v4.54.0` to the current latest `v4.55.0` ### Reference https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference Pull Request resolved: pytorch#160635 Approved by: https://github.com/ZainRizvi
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
After pytorch#160635, I can see dependabot creating the PR to bump `transformers` version at pytorch#160807. This a good start, but there are several tweaks we need: 1. Run inductor tests on the PR including one round of perf benchmark, which is always needed. So, we need `ciflow/inductor` label and a `pull_request` trigger for the benchmark 2. Per @anijain2305 feedback, we don't need to update patch version. So, I add a rule to ignore it. Again, we would need to test this out after this lands. Pull Request resolved: pytorch#160935 Approved by: https://github.com/anijain2305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal here is to use GitHub Dependabot to make sure that
transformersversion used in CI are always up-to-date. To achieve this, this PR does 2 things:transformersversion across all CI jobs to only one place at.ci/docker/ci_commit_pins/huggingface.txt. This file is now a regular pip requirements instead of a pinned commit text. There isn't any need to pintransformersto a specific commit and the file already refers to a stable versionv4.54.0.github/dependabot.ymlto config the bot to updatetransformersautomatically when there is a new version. Those labels will ensure that the right reviewers from torch.compile and Dev Infra are notified. I'm not sure how to test this out in PR, but it feels ok to land and test this in main. If this works, we should see a PR to updatev4.54.0to the current latestv4.55.0Reference
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference