Skip to content

[MPS] Add support for log_normal_ #160339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Raman-RH wants to merge 4 commits into from
Closed

[MPS] Add support for log_normal_ #160339

Raman-RH wants to merge 4 commits into from

Conversation

@Raman-RH
Copy link
Contributor

@Raman-RH Raman-RH commented Aug 11, 2025 •
edited
Loading

We have this op in list of most requested ops in MPS backend

import torch
torch.manual_seed(42)
x = torch.tensor([0.0, 0.3, -0.5, 0.7], dtype=torch.float32, device='mps')
print(x.log_normal_(1, 1))

output:

tensor([6.7172, 3.3963, 3.1457, 5.6748], device='mps:0')

cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer @jcaip @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160339

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f02bde2 with merge base 556e2a7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 13, 2025
@kurtamohler kurtamohler mentioned this pull request Aug 19, 2025
Open
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 12, 2025
@github-actions github-actions bot closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees

No one assigned

Labels

open source release notes: mps Release notes category Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Raman-RH @jerryzh168 @pytorchbot