Skip to content

[replicate][be] improved readability of test case description #160128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anshul-si wants to merge 1 commit into from
Closed

[replicate][be] improved readability of test case description #160128

anshul-si wants to merge 1 commit into from

Conversation

@anshul-si
Copy link
Contributor

@anshul-si anshul-si commented Aug 7, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160128

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a7fc145 with merge base a572596 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Aug 7, 2025
anshul-si added a commit that referenced this pull request Aug 7, 2025
@anshul-si
[replicate][be] improved readability of test case description
0493884 
ghstack-source-id: 17d21a6
Pull Request resolved: #160128
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Aug 7, 2025
@anshul-si anshul-si requested a review from mori360 August 7, 2025 19:08
mori360
mori360 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@mori360 mori360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshul-si
Copy link
Contributor Author

anshul-si commented Aug 7, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 7, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anshul-si anshul-si mentioned this pull request Aug 7, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Aug 8, 2025
@anshul-si @pytorchmergebot
[replicate][be] improved readability and cleaned up remaining DDP code (
72009ec 
#160133)

**Summary**
As much of ReplicateState functionality is copied from FSDPState, I fixed any remaining comments that incorrectly used FSDP instead of Replicate. In addition, instead of labeling modules FSDPModule or FSDPLinear, I have changed it so that is now uses Replicate____. Finally, I have removed some leftover code from the DDP implementation. I have included test cases to verify correctness.

**Test Case**
1. pytest test/distributed/_composable/test_replicate_with_fsdp.py

Pull Request resolved: #160133
Approved by: https://github.com/mori360
ghstack dependencies: #160128
hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
@anshul-si @hinriksnaer
[replicate][be] improved readability of test case description (pytorc…
ef7613e 
…h#160128)

Pull Request resolved: pytorch#160128
Approved by: https://github.com/mori360
hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
@anshul-si @hinriksnaer
[replicate][be] improved readability and cleaned up remaining DDP code (
6dfa29e 
pytorch#160133)

**Summary**
As much of ReplicateState functionality is copied from FSDPState, I fixed any remaining comments that incorrectly used FSDP instead of Replicate. In addition, instead of labeling modules FSDPModule or FSDPLinear, I have changed it so that is now uses Replicate____. Finally, I have removed some leftover code from the DDP implementation. I have included test cases to verify correctness.

**Test Case**
1. pytest test/distributed/_composable/test_replicate_with_fsdp.py

Pull Request resolved: pytorch#160133
Approved by: https://github.com/mori360
ghstack dependencies: pytorch#160128
@github-actions github-actions bot deleted the gh/anshul-si/14/head branch September 7, 2025 02:13
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@anshul-si @markc-614
[replicate][be] improved readability of test case description (pytorc…
7cd11d0 
…h#160128)

Pull Request resolved: pytorch#160128
Approved by: https://github.com/mori360
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@anshul-si @markc-614
[replicate][be] improved readability and cleaned up remaining DDP code (
a029cd2 
pytorch#160133)

**Summary**
As much of ReplicateState functionality is copied from FSDPState, I fixed any remaining comments that incorrectly used FSDP instead of Replicate. In addition, instead of labeling modules FSDPModule or FSDPLinear, I have changed it so that is now uses Replicate____. Finally, I have removed some leftover code from the DDP implementation. I have included test cases to verify correctness.

**Test Case**
1. pytest test/distributed/_composable/test_replicate_with_fsdp.py

Pull Request resolved: pytorch#160133
Approved by: https://github.com/mori360
ghstack dependencies: pytorch#160128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mori360 mori360 mori360 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anshul-si @pytorchmergebot @mori360