Skip to content

Conversation

@yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Aug 7, 2025

[ghstack-poisoned]
@yangw-dev yangw-dev requested a review from a team as a code owner August 7, 2025 17:53
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 7, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160116

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b081e0b with merge base 211c988 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: cb08ee7
Pull-Request: #160116
@yangw-dev yangw-dev changed the title vllm build workflow [3/3][ghstack][vllm ci build setup]vllm build workflow Aug 7, 2025
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: cc7732c
Pull-Request: #160116
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2025

Warning: Unknown label ciflow/vllm.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/triton_binaries
  • ciflow/inductor
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-perf-test-nightly-rocm
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-cu126
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/periodic-rocm-mi300
  • ciflow/rocm
  • ciflow/rocm-mi300
  • ciflow/s390
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/torchbench
  • ciflow/op-benchmark
  • ciflow/pull
  • ciflow/h100
  • ciflow/h100-distributed
  • ciflow/win-arm64
  • ciflow/h100-symm-mem
  • ciflow/h100-cutlass-backend

Please add the new label to .github/pytorch-probot.yml

[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: d2146b0
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: ca9ac9f
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: 9751e81
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: 8bf838d
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: 934c2eb
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: f297ab1
Pull-Request: #160116
[ghstack-poisoned]
yangw-dev added a commit that referenced this pull request Aug 7, 2025
ghstack-source-id: 6ec3c31
Pull-Request: #160116
[ghstack-poisoned]
[ghstack-poisoned]
@yangw-dev yangw-dev requested a review from huydhn August 14, 2025 22:59
[ghstack-poisoned]
[ghstack-poisoned]
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huydhn
Copy link
Contributor

huydhn commented Aug 15, 2025

Chatting with @yangw-dev on this and put the note here for future reference. As this adds a new GH action, the safe way to land this is to split this into 2 PRs. The first PR will contain everything except the change in .github/workflows/_linux-build.yml and the second one has .github/workflows/_linux-build.yml change to use the new GH action:

  1. We land the first PR, wait a day or so for it to get into viable/strict.
  2. Once (1) is done, land the second PR to use the new GH action. The assumption here is that most people would already have the first change.

Without this strategy, we might need to ask people to rebase their PRs.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@yangw-dev
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 15, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
ghstack-source-id: f3bb805
Pull-Request: pytorch/pytorch#160116
Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request Nov 17, 2025
ghstack-source-id: 06bcd3f
Pull-Request: pytorch/pytorch#160116
@github-actions github-actions bot deleted the gh/yangw-dev/14/head branch December 14, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants