-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Make user defined Triton kernels serializable for fx_graph_runnable #160002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160002
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e3f0f6c with merge base a4b07fe ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
eellison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Breaks inductor tests in trunk" -c nosignal See https://hud.pytorch.org/pytorch/pytorch/commit/4183d4ff3dcc1d87400326a9a7998c3f9e966f60 for the details |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@PaulZhang12 your PR has been successfully reverted. |
…nnable (#160002)" This reverts commit 4183d4f. Reverted #160002 on behalf of https://github.com/albanD due to Breaks inductor tests in trunk ([comment](#160002 (comment)))
…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison
…runnable (#160002)" Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187
…runnable (pytorch#160002)" (pytorch#160436) Summary: Pull Request resolved: pytorch#160436 Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187
…runnable (pytorch#160002)" (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187
…n attributes (#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: #160436 Approved by: https://github.com/clee2000
…n attributes (#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: #160436 Approved by: https://github.com/clee2000
…n attributes (#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: #160436 Approved by: https://github.com/clee2000
… contain attributes (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: pytorch#160436 Approved by: https://github.com/clee2000
…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison
…nnable (pytorch#160002)" This reverts commit 4183d4f. Reverted pytorch#160002 on behalf of https://github.com/albanD due to Breaks inductor tests in trunk ([comment](pytorch#160002 (comment)))
…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison
… contain attributes (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: pytorch#160436 Approved by: https://github.com/clee2000
Stack from ghstack (oldest at bottom):
Resolves issue #153475 where
fx_graph_runnabledidn't work with user defined triton kernels.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela