Fixes for `collections.Counter` #159368

guilhermeleobas · 2025-07-29T14:33:37Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @mlazos

[ghstack-poisoned]

pytorch-bot · 2025-07-29T14:33:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159368

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 16420cb with merge base e299926 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
vision_maskrcnn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 77440ab Pull-Request: #159368

[ghstack-poisoned]

ghstack-source-id: 95a24ee Pull-Request: #159368

[ghstack-poisoned]

torch/_dynamo/polyfills/_collections.py

[ghstack-poisoned]

mlazos

Assuming you have test coverage from the skips you removed, looks good!

pytorchmergebot · 2025-08-15T00:27:43Z

Starting merge as part of PR stack under #159483

guilhermeleobas · 2025-08-15T14:46:56Z

@pytorchbot merge

pytorchmergebot · 2025-08-15T14:49:32Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[ghstack-poisoned]

pytorchmergebot · 2025-08-15T15:10:39Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot · 2025-08-15T18:28:54Z

Starting merge as part of PR stack under #159483

Pull Request resolved: #159483 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368

#159902) Pull Request resolved: #159902 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483

…159864) Pull Request resolved: #159864 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902

…ts (#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: #159865 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864

Pull Request resolved: #159367 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864, #159865

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

Update

3dd9fe3

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Jul 29, 2025

guilhermeleobas added a commit that referenced this pull request Jul 29, 2025

Fixes for collections.Counter

359ed33

ghstack-source-id: 77440ab Pull-Request: #159368

This was referenced Jul 29, 2025

Enable trace through the collections module #159365

Closed

Change mutation type of MutableMappingVariable to AttributeMutationNew #159366

Closed

Fixes for collections.NamedTuple #159367

Closed

guilhermeleobas added the release notes: dynamo label Jul 29, 2025

Update

5442938

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jul 29, 2025

Fixes for collections.Counter

c62eba3

ghstack-source-id: 95a24ee Pull-Request: #159368

pytorchbot added the open source label Jul 29, 2025

guilhermeleobas mentioned this pull request Jul 30, 2025

Don't call _call_iter_tuple_list with UserDefinedObjectVariable arg #159402

Closed

guilhermeleobas added 6 commits July 30, 2025 12:50

Update

6447efc

[ghstack-poisoned]

Update

84a3a74

[ghstack-poisoned]

Update

46202fa

[ghstack-poisoned]

Update

605a3df

[ghstack-poisoned]

Update

51951a7

[ghstack-poisoned]

Update

5a9c7fc

[ghstack-poisoned]

guilhermeleobas marked this pull request as ready for review August 1, 2025 14:28

guilhermeleobas mentioned this pull request Aug 1, 2025

Support next(iterator, default) #159483

Closed

Skylion007 reviewed Aug 3, 2025

View reviewed changes

torch/_dynamo/polyfills/_collections.py Outdated Show resolved Hide resolved

Update

4b821de

[ghstack-poisoned]

This was referenced Aug 5, 2025

Implement list(UserDefinedObject) via force_unpack_var_sequence #159864

Closed

[collections.abc] Ensure that binop calls works with UserDefinedObjects #159865

Closed

Update

233e622

[ghstack-poisoned]

guilhermeleobas mentioned this pull request Aug 5, 2025

Wrap class definitions in set_fullgraph(False) in test_collections #159902

Closed

guilhermeleobas added 2 commits August 13, 2025 22:02

Update

fbcfd86

[ghstack-poisoned]

Update

a2ed462

[ghstack-poisoned]

mlazos approved these changes Aug 14, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 15, 2025

pytorchmergebot added the merging label Aug 15, 2025

Update

16420cb

[ghstack-poisoned]

pytorchmergebot removed the merging label Aug 15, 2025

pytorchmergebot closed this in e5621b4 Aug 15, 2025

pytorchmergebot added the Merged label Aug 15, 2025

github-actions bot deleted the gh/guilhermeleobas/217/head branch September 15, 2025 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for `collections.Counter` #159368

Fixes for `collections.Counter` #159368

Uh oh!

guilhermeleobas commented Jul 29, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

mlazos left a comment

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fixes for collections.Counter #159368

Fixes for collections.Counter #159368

Uh oh!

Conversation

guilhermeleobas commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159368

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Uh oh!

mlazos left a comment

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge failed

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fixes for `collections.Counter` #159368

Fixes for `collections.Counter` #159368

guilhermeleobas commented Jul 29, 2025 •

edited

Loading

pytorch-bot bot commented Jul 29, 2025 •

edited

Loading