-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Docker builds] Move from Miniconda to Miniforge #158370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158370
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 95 PendingAs of commit cdb4008 with merge base 9d184bd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seemethere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good although I'd say the most ideal thing would be to just remove the conda dependency altogether.
You need to remove your trailing whitespace
|
Will need to remove conda once we can remove these from Nova workflow |
Co-authored-by: Eli Uriegas <[email protected]>
|
@pytorchmergebot merge -f "CI already passed on this commit" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "this fail pr time benchmarks" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot revert -m "this fail pr time benchmarks" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 0a99b02. Reverted #158370 on behalf of https://github.com/laithsakka due to this fail pr time benchmarks ([comment](#158370 (comment)))
|
@pytorchbot merge -f "my bad reverted wrong pr" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@atalman I apologize for reverting this by mistake, I am trying to reland ASAP. |
|
Hey Team, Community & DevRel from Anaconda here. You can set the CONDA_PLUGINS_AUTO_ACCEPT_TOS environment variable to "yes" to accept the Terms of Service automatically and that will help you right now. Feel free to reach out to [email protected] or my email [email protected]. I know that the PR is merged and sorted - but I want to follow up in case conversations are happening elsewhere. We did not intend to interrupt CI workflows. A fix is coming soon (between an hour and 24 based on cache and workflows). Thanks so much for updating your documentation to follow up with the answer to the fix for your users. status page: https://anaconda.statuspage.io/ So sorry for the inconvenience. Bear with us, our open source community are important to us and we're hoping to improve clarity and convenience. A fix is coming soon. DW |
This is related to: https://www.anaconda.com/legal/terms/terms-of-service Trying to fix outage with docker builds. https://github.com/pytorch/pytorch/actions/runs/16298993712/job/46033590799 Rocm and XPU builds since they use Miniforge are not affected ``` pytorch#22 ERROR: process "/bin/sh -c bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt" did not complete successfully: exit code: 1 ------ > [base 14/42] RUN bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt: 11.93 CondaToSNonInteractiveError: Terms of Service have not been accepted for the following channels. Please accept or remove them before proceeding: 11.93 • https://repo.anaconda.com/pkgs/main 11.93 • https://repo.anaconda.com/pkgs/r 11.93 11.93 To accept a channel's Terms of Service, run the following and replace `CHANNEL` with the channel name/URL: 11.93 ‣ conda tos accept --override-channels --channel CHANNEL ``` Hence solution is: 1. using `` conda tos accept --override-channels --channel defaults`` 2. use Miniforge instead of Miniconda. Using solution 2. Solution Tried that don't work: 1. Using ``CONDA_ALWAYS_YES = true `` 4. Using older version of miniconda ``` [Miniconda3-py310_25.5.1-0-Linux-x86_64.sh](https://repo.anaconda.com/miniconda/Miniconda3-py310_25.5.1-0-Linux-x86_64.sh) ``` Pull Request resolved: pytorch#158370 Approved by: https://github.com/seemethere Co-authored-by: Eli Uriegas <[email protected]>
… (#158756) * [Docker builds] Move from Miniconda to Miniforge (#158370) This is related to: https://www.anaconda.com/legal/terms/terms-of-service Trying to fix outage with docker builds. https://github.com/pytorch/pytorch/actions/runs/16298993712/job/46033590799 Rocm and XPU builds since they use Miniforge are not affected ``` #22 ERROR: process "/bin/sh -c bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt" did not complete successfully: exit code: 1 ------ > [base 14/42] RUN bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt: 11.93 CondaToSNonInteractiveError: Terms of Service have not been accepted for the following channels. Please accept or remove them before proceeding: 11.93 • https://repo.anaconda.com/pkgs/main 11.93 • https://repo.anaconda.com/pkgs/r 11.93 11.93 To accept a channel's Terms of Service, run the following and replace `CHANNEL` with the channel name/URL: 11.93 ‣ conda tos accept --override-channels --channel CHANNEL ``` Hence solution is: 1. using `` conda tos accept --override-channels --channel defaults`` 2. use Miniforge instead of Miniconda. Using solution 2. Solution Tried that don't work: 1. Using ``CONDA_ALWAYS_YES = true `` 4. Using older version of miniconda ``` [Miniconda3-py310_25.5.1-0-Linux-x86_64.sh](https://repo.anaconda.com/miniconda/Miniconda3-py310_25.5.1-0-Linux-x86_64.sh) ``` Pull Request resolved: #158370 Approved by: https://github.com/seemethere Co-authored-by: Eli Uriegas <[email protected]> * Remove tos --------- Co-authored-by: Eli Uriegas <[email protected]>
…h#158370) (pytorch#158756) * [Docker builds] Move from Miniconda to Miniforge (pytorch#158370) This is related to: https://www.anaconda.com/legal/terms/terms-of-service Trying to fix outage with docker builds. https://github.com/pytorch/pytorch/actions/runs/16298993712/job/46033590799 Rocm and XPU builds since they use Miniforge are not affected ``` #22 ERROR: process "/bin/sh -c bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt" did not complete successfully: exit code: 1 ------ > [base 14/42] RUN bash ./install_conda.sh && rm install_conda.sh install_magma_conda.sh common_utils.sh /opt/conda/requirements-ci.txt /opt/conda/requirements-docs.txt: 11.93 CondaToSNonInteractiveError: Terms of Service have not been accepted for the following channels. Please accept or remove them before proceeding: 11.93 • https://repo.anaconda.com/pkgs/main 11.93 • https://repo.anaconda.com/pkgs/r 11.93 11.93 To accept a channel's Terms of Service, run the following and replace `CHANNEL` with the channel name/URL: 11.93 ‣ conda tos accept --override-channels --channel CHANNEL ``` Hence solution is: 1. using `` conda tos accept --override-channels --channel defaults`` 2. use Miniforge instead of Miniconda. Using solution 2. Solution Tried that don't work: 1. Using ``CONDA_ALWAYS_YES = true `` 4. Using older version of miniconda ``` [Miniconda3-py310_25.5.1-0-Linux-x86_64.sh](https://repo.anaconda.com/miniconda/Miniconda3-py310_25.5.1-0-Linux-x86_64.sh) ``` Pull Request resolved: pytorch#158370 Approved by: https://github.com/seemethere Co-authored-by: Eli Uriegas <[email protected]> * Remove tos --------- Co-authored-by: Eli Uriegas <[email protected]>
This is related to: https://www.anaconda.com/legal/terms/terms-of-service
Trying to fix outage with docker builds.
https://github.com/pytorch/pytorch/actions/runs/16298993712/job/46033590799
Rocm and XPU builds since they use Miniforge are not affected
Hence solution is:
conda tos accept --override-channels --channel defaultsUsing solution 2.
Solution Tried that don't work:
Using
CONDA_ALWAYS_YES = trueUsing older version of miniconda