Skip to content

[ONNX] Remove legacy Dort #158258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
titaiwangms wants to merge 6 commits into from
Closed

[ONNX] Remove legacy Dort #158258

titaiwangms wants to merge 6 commits into from

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Jul 14, 2025 •
edited
Loading

@titaiwangms
Update
e0d96de 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jul 14, 2025
@titaiwangms titaiwangms mentioned this pull request Jul 14, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158258

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cea8443 with merge base 5a54db1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 14, 2025
Closed
Closed
@titaiwangms
Update
6608830 
[ghstack-poisoned]
@titaiwangms titaiwangms mentioned this pull request Jul 14, 2025
Closed
@titaiwangms
Update
3b2d18b 
[ghstack-poisoned]
@titaiwangms
Update
9e3e8c7 
[ghstack-poisoned]
This was referenced Jul 14, 2025
Closed
Closed
@titaiwangms
Update
544cf27 
[ghstack-poisoned]
@titaiwangms titaiwangms mentioned this pull request Jul 14, 2025
Closed
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 15, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 15, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2025

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 15, 2025

@malfet PTAL
The PR is removing onnxrt from dynamo backend.

malfet
malfet approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if it might be considered BC-breaking

@titaiwangms titaiwangms added the topic: bc breaking topic category label Jul 15, 2025
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b41ca54913407f550487639b1aad6a2a2c3234d3 returned non-zero exit code 1

Auto-merging torch/onnx/__init__.py
CONFLICT (content): Merge conflict in torch/onnx/__init__.py
error: could not apply b41ca549134... [ONNX] Remove legacy Dort
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@titaiwangms
Update
cea8443 
[ghstack-poisoned]
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 15, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 15, 2025
@titaiwangms @pytorchmergebot
[ONNX] Remove legacy dynamo graph extractor (#158262)
205241a 
Pull Request resolved: #158262
Approved by: https://github.com/justinchuby
ghstack dependencies: #158258
pytorchmergebot pushed a commit that referenced this pull request Jul 15, 2025
@titaiwangms @pytorchmergebot
[ONNX] Remove fx_onnx_interpreter.py (#158282)
e4c17d5 
Pull Request resolved: #158282
Approved by: https://github.com/Skylion007, https://github.com/justinchuby
ghstack dependencies: #158258, #158262
pytorchmergebot pushed a commit that referenced this pull request Jul 15, 2025
@titaiwangms @pytorchmergebot
[ONNX] Remove legacy registration and dispatcher (#158283)
3f83e3e 
Pull Request resolved: #158283
Approved by: https://github.com/Skylion007, https://github.com/justinchuby
ghstack dependencies: #158258, #158262, #158282
@github-actions github-actions bot deleted the gh/titaiwangms/4/head branch August 15, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@justinchuby justinchuby justinchuby approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@titaiwangms @pytorchmergebot @malfet @justinchuby @pytorchbot