[Easy] Fix the compilation warning #157889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157889
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fce9a1f with merge base e5edd01 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
fffrog
added a commit
that referenced
this pull request
Jul 9, 2025
**Background:** ```Shell [1376/2332] Building CUDA object caffe2/CMakeFiles/torch_...h/csrc/distributed/c10d/symm_mem/NCCLSymmetricMemory.cu.o /root/Git.d/pytorch/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.hpp(450): warning #68-D: integer conversion resulted in a change of sign size_t numelIn_ = -1; ^ Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" /root/Git.d/pytorch/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.hpp(451): warning #68-D: integer conversion resulted in a change of sign size_t numelOut_ = -1; ^ /root/Git.d/pytorch/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.hpp(450): warning #68-D: integer conversion resulted in a change of sign size_t numelIn_ = -1; ^ Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" /root/Git.d/pytorch/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.hpp(451): warning #68-D: integer conversion resulted in a change of sign size_t numelOut_ = -1; ``` ghstack-source-id: 3fd5998 Pull-Request-resolved: #157889
Collaborator
Author
|
@pytorchbot label "topic: not user facing" |
mlazos
approved these changes
Jul 9, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fduwjj
reviewed
Jul 9, 2025
Comment on lines
-450
to
-451
| size_t numelIn_ = -1; | ||
| size_t numelOut_ = -1; |
Contributor
There was a problem hiding this comment.
This change is ok to me but I forgot why we originally want to make it -1.... I checked the original PR #100413 this should be fine. Thanks for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Background:
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k