Skip to content

Add PEP 517 compliant Python source distribution to release process #157815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zklaus wants to merge 25 commits into from
Closed

Add PEP 517 compliant Python source distribution to release process #157815

zklaus wants to merge 25 commits into from

Conversation

@zklaus
Copy link
Collaborator

@zklaus zklaus commented Jul 8, 2025 •
edited
Loading

This adds the actual creation of a standards compliant sdist along with its upload to s3 to the create release workflow.

Stack from ghstack (oldest at bottom):

@zklaus
Update
0bd8e5b 
[ghstack-poisoned]
@zklaus zklaus requested a review from a team as a code owner July 8, 2025 16:22
This was referenced Jul 8, 2025
Closed
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157815

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d40104 with merge base 3a7db34 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zklaus zklaus mentioned this pull request Jul 8, 2025
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 8, 2025
zklaus added a commit that referenced this pull request Jul 8, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
36f4d58 
ghstack-source-id: 8536eeb
Pull Request resolved: #157815
@zklaus zklaus mentioned this pull request Jul 8, 2025
Closed
@zklaus
Update
a6bf90b 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Jul 29, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
b1a36da 
ghstack-source-id: 0aa45b3
Pull Request resolved: #157815
@zklaus
Update
97e381d 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Jul 29, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
4ab976b 
ghstack-source-id: db2d413
Pull Request resolved: #157815
@zklaus
Update
9739f45 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Jul 29, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
e955d76 
ghstack-source-id: 1d0a63a
Pull Request resolved: #157815
@zklaus
Update
6e7e294 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Aug 8, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
4b3a501 
ghstack-source-id: bc6a9f5
Pull Request resolved: #157815
@zklaus
Update
13134ce 
[ghstack-poisoned]
@zklaus zklaus mentioned this pull request Aug 11, 2025
Closed
zklaus added a commit that referenced this pull request Aug 11, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
d18a010 
ghstack-source-id: 893693c
Pull Request resolved: #157815
@zklaus
Update
c89103f 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Aug 11, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
8f19082 
ghstack-source-id: b252912
Pull Request resolved: #157815
@zklaus
Update
eea55dd 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Aug 12, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
b993e73 
ghstack-source-id: 061d3fb
Pull Request resolved: #157815
@zklaus
Update
7c2a9f7 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 2, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
14799bf 
ghstack-source-id: 1d91581
Pull Request resolved: #157815
zklaus added a commit that referenced this pull request Sep 17, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
c0d8e26 
ghstack-source-id: 2ac2ebe
Pull Request resolved: #157815
@zklaus
Update
09ff731 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 18, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
23a483d 
ghstack-source-id: 7291105
Pull Request resolved: #157815
@zklaus
Update
cc93948 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 18, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
bbfc925 
ghstack-source-id: 412b3bb
Pull Request resolved: #157815
@zklaus
Update
bd0fbe3 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 19, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
cca91da 
ghstack-source-id: d4cf52d
Pull Request resolved: #157815
@zklaus
Update
fd888a1 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 19, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
0195052 
ghstack-source-id: 55fe1ed
Pull Request resolved: #157815
@zklaus
Update
501bb01 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 19, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
d6b1a4d 
ghstack-source-id: bdf5a18
Pull Request resolved: #157815
@zklaus
Update
9d40104 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 22, 2025
@zklaus
Add PEP 517 compliant Python source distribution to release process
7c69440 
ghstack-source-id: 7d289ec
Pull Request resolved: #157815
@zklaus
Copy link
Collaborator Author

zklaus commented Sep 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 24, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / build

Details for Dev Infra team Raised by workflow job

@zklaus
Copy link
Collaborator Author

zklaus commented Sep 25, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@zklaus @jainapurva
Add PEP 517 compliant Python source distribution to release process (#…
5ba7849 
…157815)

This adds the actual creation of a standards compliant sdist along with its upload to s3 to the create release workflow.

Pull Request resolved: #157815
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: #157814, #160315
@rgommers
Copy link
Collaborator

rgommers commented Oct 16, 2025

Great to see this re-landed. @zklaus did this make it into the 2.9.0 release? I.e., is pytorch-v2.9.0.tar.gz at https://github.com/pytorch/pytorch/releases/tag/v2.9.0 a proper sdist?

@zklaus
Copy link
Collaborator Author

zklaus commented Oct 17, 2025

Great to see this re-landed. @zklaus did this make it into the 2.9.0 release? I.e., is pytorch-v2.9.0.tar.gz at v2.9.0 (release) a proper sdist?

No, it was delayed until after the branch cut. When the sdist shows up, it will be as torch-v2.10.0.tar.gz.

@github-actions github-actions bot deleted the gh/zklaus/18/head branch November 17, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zklaus @pytorchmergebot @rgommers @malfet @atalman @pytorchbot