Improve MANIFEST.in for source distribution #157814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157814
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 6461738 with merge base 3a7db34 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 8, 2025
XuehaiPan
reviewed
Jul 9, 2025
XuehaiPan
reviewed
Jul 9, 2025
XuehaiPan
requested changes
Jul 9, 2025
Collaborator
|
Will need to add a test for the SDist: $ uv pip install -v torch-*.tar.gz
DEBUG uv 0.8.3 (Homebrew 2025-07-24)
DEBUG Searching for default Python interpreter in virtual environments
DEBUG Found `cpython-3.13.5-macos-aarch64-none` at `/Users/PanXuehai/Projects/pytorch/dist/venv/bin/python3` (active virtual environment)
Using Python 3.13.5 environment at: venv
DEBUG Acquired lock for `venv`
DEBUG At least one requirement is not satisfied: file:///Users/PanXuehai/Projects/pytorch/dist/torch-2.9.0a0+gite955d76.tar.gz
...
DEBUG adding 'torchgen/selective_build/selector.py'
DEBUG adding 'torchgen/static_runtime/__init__.py'
DEBUG adding 'torchgen/static_runtime/config.py'
DEBUG adding 'torchgen/static_runtime/gen_static_runtime_ops.py'
DEBUG adding 'torchgen/static_runtime/generator.py'
DEBUG adding 'torch-2.9.0a0+gitunknown.dist-info/METADATA'
DEBUG adding 'torch-2.9.0a0+gitunknown.dist-info/WHEEL'
DEBUG adding 'torch-2.9.0a0+gitunknown.dist-info/entry_points.txt'
DEBUG adding 'torch-2.9.0a0+gitunknown.dist-info/top_level.txt'
DEBUG adding 'torch-2.9.0a0+gitunknown.dist-info/RECORD'
DEBUG removing build/bdist.macosx-15.0-arm64/wheel
DEBUG Released lock at `/var/folders/9r/g38s_wqs3kg0cy0n0mcdq92h0000gn/T/uv-setuptools-b139a3b1e08b9b31.lock`
DEBUG Released lock at `/Users/PanXuehai/.cache/uv/sdists-v9/path/da64d06ad13a9430/.lock`
× Failed to build `torch @ file:///Users/PanXuehai/Projects/pytorch/dist/torch-2.9.0a0+gite955d76.tar.gz`
╰─▶ Package metadata version `2.9.0a0+gitunknown` does not match given version `2.9.0a0+gite955d76`
DEBUG Released lock at `/Users/PanXuehai/Projects/pytorch/dist/venv/.lock` |
Collaborator
Author
Good catch about the version number. This happens because the version is (should be) fixed at the time of building the sdist, but is recalculated by setup.py when building the wheel from the sdist, now with the git information missing. The solution is to take the version information from the sdist at wheel-build time, which I implemented in #160315. |
XuehaiPan
added
module: build
XuehaiPan
reviewed
Sep 19, 2025
XuehaiPan
reviewed
Sep 19, 2025
XuehaiPan
reviewed
Sep 19, 2025
Collaborator
Author
|
Thanks, @XuehaiPan! I have addressed your comments and also updated the manifest with some small changes that happened more recently. |
XuehaiPan
approved these changes
Sep 19, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
Collaborator
|
Starting merge as part of PR stack under #157815 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #157815 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 25, 2025
The version finding logic triggered from `setup.py` generally tries to take the git information into account. This is fine for most situations where we are building from a checkout, but it creates a problem in the case of sdists, as here the version is determined at the time of sdist creation, taking the git information into account, but then later recalculated when building wheels or installing from the sdist, now with the git information missing. The solution is to take the version information directly from the sdist, which this PR adds by means of parsing the `PKG-INFO` which marks an unpacked sdist. Pull Request resolved: #160315 Approved by: https://github.com/atalman ghstack dependencies: #157814
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 25, 2025
…157815) This adds the actual creation of a standards compliant sdist along with its upload to s3 to the create release workflow. Pull Request resolved: #157815 Approved by: https://github.com/malfet, https://github.com/atalman ghstack dependencies: #157814, #160315
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
The version finding logic triggered from `setup.py` generally tries to take the git information into account. This is fine for most situations where we are building from a checkout, but it creates a problem in the case of sdists, as here the version is determined at the time of sdist creation, taking the git information into account, but then later recalculated when building wheels or installing from the sdist, now with the git information missing. The solution is to take the version information directly from the sdist, which this PR adds by means of parsing the `PKG-INFO` which marks an unpacked sdist. Pull Request resolved: #160315 Approved by: https://github.com/atalman ghstack dependencies: #157814
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
…157815) This adds the actual creation of a standards compliant sdist along with its upload to s3 to the create release workflow. Pull Request resolved: #157815 Approved by: https://github.com/malfet, https://github.com/atalman ghstack dependencies: #157814, #160315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @seemethere @malfet @atalman