Skip to content

Make functorch notebook symlinks PEP 517 valid #157813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zklaus wants to merge 11 commits into from
Closed

Make functorch notebook symlinks PEP 517 valid #157813

zklaus wants to merge 11 commits into from

Conversation

@zklaus
Copy link
Collaborator

@zklaus zklaus commented Jul 8, 2025 •
edited
Loading

@zklaus
Update
1c36f97 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157813

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fa21577 with merge base 1274297 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 8, 2025
Closed
Closed
Closed
Closed
@malfet malfet requested a review from zou3519 July 8, 2025 16:49
@malfet malfet added the topic: not user facing topic category label Jul 8, 2025
zklaus added 5 commits July 29, 2025 14:15
@zklaus
Update
ecc2c00 
[ghstack-poisoned]
@zklaus
Update
7223b76 
[ghstack-poisoned]
@zklaus
Update
e3daaca 
[ghstack-poisoned]
@zklaus
Update
c0bc56b 
[ghstack-poisoned]
@zklaus
Update
5df7374 
[ghstack-poisoned]
@zklaus zklaus mentioned this pull request Aug 11, 2025
Closed
@zklaus
Copy link
Collaborator Author

zklaus commented Aug 11, 2025

I think the linter error is spurious: As a file (a symlink) is replaced with a directory, the comparison of permissions doesn't work as expected, hence the error can be ignored, imho.

@zklaus
Copy link
Collaborator Author

zklaus commented Aug 12, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 12, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 12, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@zklaus
Update
1905911 
[ghstack-poisoned]
@zklaus
Copy link
Collaborator Author

zklaus commented Sep 4, 2025

Per request from @atalman, this stack will be landed as-is after the release branch cut, currently scheduled for 2025-09-08.

@zklaus
Update
d52f1c7 
[ghstack-poisoned]
@zklaus
Copy link
Collaborator Author

zklaus commented Sep 10, 2025

@pytorchbot merge -f "Linter chokes on unusual but correct replacement of symbolic link."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 10, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Sep 10, 2025

@pytorchbot revert -m 'Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally' -c ghfirst

Basically, functorch/docs/source/notebooks file changes to functorch/docs/source/notebooks directory messed up Mecurial. Is this possible to change the name of the directory and reland this change?

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 10, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 10, 2025
@pytorchmergebot
Revert "Make functorch notebook symlinks PEP 517 valid (#157813)"
053251b 
This reverts commit b494547.

Reverted #157813 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally ([comment](#157813 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 10, 2025

@zklaus your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 10, 2025
@zklaus
Update
2638964 
[ghstack-poisoned]
@zklaus
Update
cae2217 
[ghstack-poisoned]
@zklaus
Update
fa21577 
[ghstack-poisoned]
@zklaus
Copy link
Collaborator Author

zklaus commented Sep 11, 2025

@huydhn, to address the issue, I have renamed the folder in docs/source to tutorials (as which it is referred to in the docs anyways), completely removed the outer symlink, and adapted all references accordingly.

Will reland after successful CI.

@zklaus
Copy link
Collaborator Author

zklaus commented Sep 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@zklaus @markc-614
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
b3ad93a 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "Make functorch notebook symlinks PEP 517 valid (pytorch#157813)"
729712b 
This reverts commit b494547.

Reverted pytorch#157813 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally ([comment](pytorch#157813 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@zklaus @markc-614
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
9923aea 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@zklaus @mansiag05
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
39a45c8 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "Make functorch notebook symlinks PEP 517 valid (pytorch#157813)"
6809642 
This reverts commit b494547.

Reverted pytorch#157813 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally ([comment](pytorch#157813 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@zklaus @mansiag05
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
dbe9cce 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@zklaus @cleonard530
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
f29a1c7 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "Make functorch notebook symlinks PEP 517 valid (pytorch#157813)"
774b4ca 
This reverts commit b494547.

Reverted pytorch#157813 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally ([comment](pytorch#157813 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@zklaus @cleonard530
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
7b76b34 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@zklaus @dsashidh
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
2c5e080 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "Make functorch notebook symlinks PEP 517 valid (pytorch#157813)"
a95cdb5 
This reverts commit b494547.

Reverted pytorch#157813 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but this surfaces a weird discrepancy between GitHub and Mecurial used internally ([comment](pytorch#157813 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@zklaus @dsashidh
Make functorch notebook symlinks PEP 517 valid (pytorch#157813)
e529507 
Pull Request resolved: pytorch#157813
Approved by: https://github.com/zou3519, https://github.com/atalman
@github-actions github-actions bot deleted the gh/zklaus/16/head branch October 13, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zklaus @pytorchmergebot @huydhn @zou3519 @atalman @malfet @pytorchbot