-
Notifications
You must be signed in to change notification settings - Fork 26.3k
unskipped mobilenet_v3 quantization and mobilenet_v2 quantization plus tests from https://github.com/pytorch/pytorch/issues/125438 #157786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157786
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3f1b352 with merge base c9485f8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI we are also deprecating these older quant flows including numeric suite pytorch/ao#2259
|
Looks like I don't have the power to merge, does pass all the linting checks now though :) |
Good to know! Thanks :) |
|
Also unskipped a further test which now passes on M1. |
|
@pytorchbot label "module: arm" |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
@pytorchbot label "module: arm" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Breaks lint" -c ignoredsignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…tion plus tests from #125438 (#157786)" This reverts commit 3a2c3c8. Reverted #157786 on behalf of https://github.com/albanD due to Breaks lint ([comment](#157786 (comment)))
|
@christinaburge your PR has been successfully reverted. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
…s tests from pytorch#125438 (pytorch#157786) These tests now pass on AArch64 in our downstream CI. `test_quantization.py::TestNumericSuiteEager::test_mobilenet_v2 <- test/quantization/eager/test_numeric_suite_eager.py PASSED [2.4434s] [ 35%]` Pull Request resolved: pytorch#157786 Approved by: https://github.com/jerryzh168, https://github.com/malfet
…tion plus tests from pytorch#125438 (pytorch#157786)" This reverts commit 3a2c3c8. Reverted pytorch#157786 on behalf of https://github.com/albanD due to Breaks lint ([comment](pytorch#157786 (comment)))
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…ts as these now pass on aarch64
|
Successfully rebased |
87c7084 to
3f1b352
Compare
|
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
cc: @robert-hardwick - this PR went forgotten and needs a new owner. |
These tests now pass on AArch64 in our downstream CI.
test_quantization.py::TestNumericSuiteEager::test_mobilenet_v2 <- test/quantization/eager/test_numeric_suite_eager.py PASSED [2.4434s] [ 35%]cc @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01 @nWEIdia @malfet