Skip to content

Conversation

@christinaburge
Copy link
Contributor

@christinaburge christinaburge commented Jul 8, 2025

These tests now pass on AArch64 in our downstream CI.

test_quantization.py::TestNumericSuiteEager::test_mobilenet_v2 <- test/quantization/eager/test_numeric_suite_eager.py PASSED [2.4434s] [ 35%]

cc @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01 @nWEIdia @malfet

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157786

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3f1b352 with merge base c9485f8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: quantization release notes category topic: not user facing topic category labels Jul 8, 2025
jerryzh168
jerryzh168 previously approved these changes Jul 8, 2025
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we are also deprecating these older quant flows including numeric suite pytorch/ao#2259

@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 8, 2025
@christinaburge
Copy link
Contributor Author

Looks like I don't have the power to merge, does pass all the linting checks now though :)

@christinaburge
Copy link
Contributor Author

FYI we are also deprecating these older quant flows including numeric suite pytorch/ao#2259

Good to know! Thanks :)

@christinaburge
Copy link
Contributor Author

Also unskipped a further test which now passes on M1.

@christinaburge christinaburge changed the title unskipped mobilenet_v3 quantization and mobilenet_v2 quantization unskipped mobilenet_v3 quantization and mobilenet_v2 quantization plus tests from https://github.com/pytorch/pytorch/issues/125438 Jul 10, 2025
@nikhil-arm
Copy link
Collaborator

@pytorchbot label "module: arm"

@nikhil-arm
Copy link
Collaborator

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot pytorch-bot bot added the ciflow/linux-aarch64 linux aarch64 CI workflow label Jul 21, 2025
@nikhil-arm
Copy link
Collaborator

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Jul 21, 2025
@nikhil-arm
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@nikhil-arm
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@aditew01
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Aug 7, 2025

@pytorchbot revert -m "Breaks lint" -c ignoredsignal

https://hud.pytorch.org/pytorch/pytorch/commit/8cb91e20bc205b1416648d0ffd98d1ba1f3a6fc4

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 7, 2025
@pytorchmergebot
Copy link
Collaborator

@christinaburge your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 7, 2025
@pytorch-bot pytorch-bot bot dismissed stale reviews from jerryzh168 and malfet August 7, 2025 13:09

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…s tests from pytorch#125438 (pytorch#157786)

These tests now pass on AArch64 in our downstream CI.

`test_quantization.py::TestNumericSuiteEager::test_mobilenet_v2 <- test/quantization/eager/test_numeric_suite_eager.py PASSED [2.4434s] [ 35%]`

Pull Request resolved: pytorch#157786
Approved by: https://github.com/jerryzh168, https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@aditew01
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 17, 2025
@linux-foundation-easycla
Copy link

CLA Not Signed

@pytorch-bot pytorch-bot bot removed the ciflow/linux-aarch64 linux aarch64 CI workflow label Sep 17, 2025
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Nov 16, 2025
@fadara01
Copy link
Collaborator

fadara01 commented Nov 16, 2025

cc: @robert-hardwick - this PR went forgotten and needs a new owner.
s this still needed anyways?

@github-actions github-actions bot closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 open source release notes: quantization release notes category Reverted Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants