-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Fix cuda 12.9 aarch64 GPU builds. Update CUDA_STABLE variable. #157630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157630
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 158 PendingAs of commit e3d80a0 with merge base a46ea8a ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| TRITON_CONSTRAINT="platform_system == 'Linux' and platform_machine == 'x86_64'" | ||
|
|
||
| # CUDA 12.8 builds have triton for Linux and Linux aarch64 binaries. | ||
| if [[ "$DESIRED_CUDA" == cu128 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point can't retrieve this via .github/scripts/get_ci_variable.py on windows and aarch64 instances when this script is run. Python is not installed yet. Will propose BE PR to move config CUDA_STABLE, PYTORCH_EXTRA_INSTALL_REQUIREMENTS etc... from python to json. This way we can easily consume it via bash or python.
|
@pytorchmergebot merge -f "lint is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.8 -c critical |
This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch: 1. The PR #155819 missed to include triton change. 2. CUDA STABLE variable needs to be set to 12.8. Updating CUDA stable updates full static build Pull Request resolved: #157630 Approved by: https://github.com/Skylion007, https://github.com/jeanschmidt (cherry picked from commit 7275f28)
Cherry picking #157630The cherry pick PR is at #157641 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Fix cuda 12.9 aarch64 GPU builds. Update CUDA_STABLE variable. (#157630) This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch: 1. The PR #155819 missed to include triton change. 2. CUDA STABLE variable needs to be set to 12.8. Updating CUDA stable updates full static build Pull Request resolved: #157630 Approved by: https://github.com/Skylion007, https://github.com/jeanschmidt (cherry picked from commit 7275f28) Co-authored-by: Andrey Talman <[email protected]>
This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch: