Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jul 4, 2025

This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch:

  1. The PR Add CUDA 12.9.1 sbsa nightly binaries #155819 missed to include triton change.
  2. CUDA STABLE variable needs to be set to 12.8. Updating CUDA stable updates full static build

@atalman atalman requested a review from a team as a code owner July 4, 2025 14:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157630

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 158 Pending

As of commit e3d80a0 with merge base a46ea8a (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 4, 2025
@atalman atalman changed the title Update CUDA_STABLE variable. Fix cuda aarch64 builds Fix cuda 12.9 aarch64 GPU builds. Update CUDA_STABLE variable. Jul 4, 2025
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jul 4, 2025
TRITON_CONSTRAINT="platform_system == 'Linux' and platform_machine == 'x86_64'"

# CUDA 12.8 builds have triton for Linux and Linux aarch64 binaries.
if [[ "$DESIRED_CUDA" == cu128 ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point can't retrieve this via .github/scripts/get_ci_variable.py on windows and aarch64 instances when this script is run. Python is not installed yet. Will propose BE PR to move config CUDA_STABLE, PYTORCH_EXTRA_INSTALL_REQUIREMENTS etc... from python to json. This way we can easily consume it via bash or python.

@atalman
Copy link
Contributor Author

atalman commented Jul 4, 2025

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Jul 4, 2025

@pytorchbot cherry-pick --onto release/2.8 -c critical

pytorchbot pushed a commit that referenced this pull request Jul 4, 2025
This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch:
1. The PR #155819 missed to include triton change.
2. CUDA STABLE variable needs to be set to 12.8. Updating CUDA stable updates full static build

Pull Request resolved: #157630
Approved by: https://github.com/Skylion007, https://github.com/jeanschmidt

(cherry picked from commit 7275f28)
@pytorchbot
Copy link
Collaborator

Cherry picking #157630

The cherry pick PR is at #157641 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman added a commit that referenced this pull request Jul 4, 2025
Fix cuda 12.9 aarch64 GPU builds. Update CUDA_STABLE variable.  (#157630)

This contains 2 fixes that required in main and will need to be cherry-picked to Release 2.8 branch:
1. The PR #155819 missed to include triton change.
2. CUDA STABLE variable needs to be set to 12.8. Updating CUDA stable updates full static build

Pull Request resolved: #157630
Approved by: https://github.com/Skylion007, https://github.com/jeanschmidt

(cherry picked from commit 7275f28)

Co-authored-by: Andrey Talman <[email protected]>
@github-actions github-actions bot deleted the atalman-patch-4 branch August 4, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants