Skip to content

Add explicit typing to nn.Module.__init__() parameters #157389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsashidh wants to merge 1 commit into from
Closed

Add explicit typing to nn.Module.__init__() parameters #157389

dsashidh wants to merge 1 commit into from

Conversation

@dsashidh
Copy link
Contributor

@dsashidh dsashidh commented Jul 1, 2025

Fixes #156740

Adds explicit Any typing to *args and **kwargs in nn.Module.__init__() to fix type checker errors in strict mode.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157389

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 572693b with merge base 0815091 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dsashidh
Copy link
Contributor Author

dsashidh commented Jul 1, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 1, 2025
Skylion007
Skylion007 approved these changes Jul 2, 2025
View reviewed changes
torch/nn/modules/module.py
_compiled_call_impl: Optional[Callable] = None

def __init__(self, *args, **kwargs) -> None:
def __init__(self, *args: Any, **kwargs: Any) -> None:
Copy link
Collaborator

@Skylion007 Skylion007 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it makes a difference but args could be a TypeVarTuple and kwargs could be Dict[str, Any]

@Skylion007
Copy link
Collaborator

Skylion007 commented Aug 31, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 31, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 31, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 1, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@dsashidh
Copy link
Contributor Author

dsashidh commented Sep 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 2, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@dsashidh
Copy link
Contributor Author

dsashidh commented Sep 8, 2025

Hi @Skylion007 the CI merge job for my PR failed due to a container error (No such container) and permissions issue. Could you please resolve this and re-trigger the job? Thanks!

@isuruf
Copy link
Collaborator

isuruf commented Sep 19, 2025

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

Successfully rebased fix-nn-module-init-typing onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-nn-module-init-typing && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix-nn-module-init-typing branch from 70cdc31 to 572693b Compare September 19, 2025 13:46
@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 19, 2025
@isuruf
Copy link
Collaborator

isuruf commented Sep 19, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 19, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@dsashidh @mansiag05
Add explicit typing to nn.Module.__init__() parameters (pytorch#157389)
77ed345 
Fixes pytorch#156740

Adds explicit `Any` typing to `*args` and `**kwargs` in `nn.Module.__init__()` to fix type checker errors in strict mode.
Pull Request resolved: pytorch#157389
Approved by: https://github.com/Skylion007, https://github.com/Raman-RH
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@dsashidh @cleonard530
Add explicit typing to nn.Module.__init__() parameters (pytorch#157389)
3f22629 
Fixes pytorch#156740

Adds explicit `Any` typing to `*args` and `**kwargs` in `nn.Module.__init__()` to fix type checker errors in strict mode.
Pull Request resolved: pytorch#157389
Approved by: https://github.com/Skylion007, https://github.com/Raman-RH
dsashidh added a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@dsashidh
Add explicit typing to nn.Module.__init__() parameters (pytorch#157389)
487611b 
Fixes pytorch#156740

Adds explicit `Any` typing to `*args` and `**kwargs` in `nn.Module.__init__()` to fix type checker errors in strict mode.
Pull Request resolved: pytorch#157389
Approved by: https://github.com/Skylion007, https://github.com/Raman-RH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

+1 more reviewer

@Raman-RH Raman-RH Raman-RH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add explicit typing to nn.Module __init__()

6 participants

@dsashidh @Skylion007 @pytorchmergebot @isuruf @Raman-RH @pytorchbot