Skip to content

Replace setup.py develop with pip install -e #156710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zklaus wants to merge 6 commits into from
Closed

Replace setup.py develop with pip install -e #156710

zklaus wants to merge 6 commits into from

Conversation

@zklaus
Copy link
Collaborator

@zklaus zklaus commented Jun 24, 2025 •
edited
Loading

@zklaus
Update
faf1370 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156710

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ec80777 with merge base 6737e2c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jun 24, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 24, 2025
This was referenced Jun 24, 2025
Closed
Closed
Closed
Closed
@Skylion007
Copy link
Collaborator

Skylion007 commented Jun 24, 2025

Refactoring this to scikit-build would let us do native inplace builds and vastly simplify our building code.

zklaus added 2 commits June 25, 2025 14:24
@zklaus
Update
3f87b01 
[ghstack-poisoned]
@zklaus
Update
ddb24b0 
[ghstack-poisoned]
@zklaus zklaus marked this pull request as ready for review August 11, 2025 11:22
@zklaus zklaus requested a review from a team as a code owner August 11, 2025 11:22
zklaus added 3 commits August 11, 2025 18:18
@zklaus
Update
f2cc713 
[ghstack-poisoned]
@zklaus
Update
0ea289c 
[ghstack-poisoned]
@zklaus
Update
ec80777 
[ghstack-poisoned]
@zklaus zklaus mentioned this pull request Sep 2, 2025
Closed
@atalman atalman added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 2, 2025
atalman
atalman approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes

malfet
malfet reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a fallback in setup.py that invokes pip install -e if someone tries to use it with new setuptools in a new way?

@zklaus
Copy link
Collaborator Author

zklaus commented Sep 4, 2025

Should we have a fallback in setup.py that invokes pip install -e if someone tries to use it with new setuptools in a new way?

I don't think so. The issue is that pip will invoke setup.py itself at some point, but not as a separate process, rather basically as eval(read(setup.py)).

Plus, what already happens now is that when one calls setup.py directly with a sufficiently new version of setuptools installed, a warning is displayed that this is deprecated and that one should use pip (or similar).
I expect that when the support is fully removed, there will still be a message that points users in the right direction.

@zklaus
Copy link
Collaborator Author

zklaus commented Sep 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@zklaus @markc-614
Replace setup.py develop with pip install -e (pytorch#156710)
fa804ce 
pytorch#156027 already replaced most use of `python setup.py develop`. This PR only adds a few more occurrences.

Pull Request resolved: pytorch#156710
Approved by: https://github.com/atalman
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@zklaus @mansiag05
Replace setup.py develop with pip install -e (pytorch#156710)
e61a8ce 
pytorch#156027 already replaced most use of `python setup.py develop`. This PR only adds a few more occurrences.

Pull Request resolved: pytorch#156710
Approved by: https://github.com/atalman
@zklaus zklaus mentioned this pull request Sep 26, 2025
Closed
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@zklaus @dsashidh
Replace setup.py develop with pip install -e (pytorch#156710)
0260897 
pytorch#156027 already replaced most use of `python setup.py develop`. This PR only adds a few more occurrences.

Pull Request resolved: pytorch#156710
Approved by: https://github.com/atalman
@github-actions github-actions bot deleted the gh/zklaus/9/head branch October 5, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet left review comments

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: onnx torch.onnx related changes that should show up in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zklaus @Skylion007 @pytorchmergebot @malfet @atalman @facebook-github-bot @pytorchbot