layernorm tests: Tweak test thresholds for comparing tensors #156699
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156699
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit acb0139 with merge base 82eefae ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@ahmadsharif1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ahmadsharif1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@eqy feel free to merge it since I am not authorized to do a merge. |
|
@ahmadsharif1 has imported this pull request. If you are a Meta employee, you can view this in D77225578. |
|
@ahmadsharif1 has imported this pull request. If you are a Meta employee, you can view this in D77225578. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…#156699) After I landed this PR: pytorch#156600, this test was failing internally on large tensors because the differences were greater than tolerances on some cuda devices. We now raise the tolerances for larger tensors. Pull Request resolved: pytorch#156699 Approved by: https://github.com/eqy, https://github.com/ngimel (cherry picked from commit 36dd598)
…nsors (#2583) After PR: pytorch#156600, this test was failing internally on large tensors because the differences were greater than tolerances on some cuda devices. We now raise the tolerances for larger tensors. Pull Request resolved: pytorch#156699 Approved by: https://github.com/eqy, https://github.com/ngimel (cherry picked from commit 36dd598) Fixes SWDEV-547998 Co-authored-by: Ahmad Sharif <[email protected]>
5 participants
After I landed this PR: #156600, this test was failing internally on large tensors because the differences were greater than tolerances on some cuda devices.
We now raise the tolerances for larger tensors.