Skip to content

Add Windows cuda 12.9.1 build #156630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 11 commits into from
Closed

Add Windows cuda 12.9.1 build #156630

atalman wants to merge 11 commits into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jun 23, 2025 •
edited
Loading

Without Support for SegmentReduce.cu
Test PR confirmed by Removing SegmentReduce.cu windows build for CUDA 12.9 can succeed

Related to: #156181

@atalman atalman requested review from a team, eqy and syed-ahmed as code owners June 23, 2025 19:27
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156630

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 162 Pending

As of commit 6031650 with merge base d061a02 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jun 23, 2025
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 23, 2025
@atalman atalman added the topic: not user facing topic category label Jun 23, 2025
malfet
malfet reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have some sort of manual test plan, i.e. that one can downloads win+cu126 wheels can can still run segment reduce there

Also, add #else clause to your ifdef that adds implementation of those functions with `TORCH_CHECK(false, "Cant' compile segment reduce, see issue number")

malfet
malfet reviewed Jun 23, 2025
View reviewed changes
@atalman
Copy link
Contributor Author

atalman commented Jun 24, 2025

@pytorchmergebot merge -f "lint is green, builds where already tested "

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 24, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@tinglvv tinglvv mentioned this pull request Jun 25, 2025
Open
12 tasks
@luncliff luncliff mentioned this pull request Aug 5, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @malfet @tinglvv