initialize with ident value in global reduction #15653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
if possible, add a test covering the case. |
apaszke
reviewed
Jan 2, 2019
test/test_cuda.py
Outdated
Contributor
There was a problem hiding this comment.
Please also add a comment explaining why do we need to test this. Is it that we use different kernels for large vs small inputs? Those things are super helpful when refactoring the tests.
Collaborator
Author
There was a problem hiding this comment.
There is now a single kernel for all reductions, with the different options. I'm not sure all the possible options are thoroughly tested, it would be a good idea to test them, but I don't know exactly in which cases which options are triggered.
soumith
approved these changes
Jan 3, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
fixed via #15647 which is landing |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 3, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 3, 2019
Summary: Fixes #15647. cc colesbury. Pull Request resolved: pytorch/pytorch#15653 Differential Revision: D13571132 Pulled By: soumith fbshipit-source-id: 8f25943c974b3b931f4528e0e0a370bc095dab51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15647. cc @colesbury.