Skip to content

[TEST] Triton 3.4.0 pin update #156186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 5 commits into from
Closed

[TEST] Triton 3.4.0 pin update #156186

atalman wants to merge 5 commits into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jun 17, 2025 •
edited
Loading

Rebase of Test: #153117

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156186

Note: Links to docs will display an error until the docs builds have been completed.

❌ 51 New Failures, 1 Cancelled Job

As of commit 1923ec2 with merge base ebab279 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 17, 2025
@atalman atalman added keep-going Don't stop on first failure, keep running tests until the end ciflow/rocm Trigger "default" config CI on ROCm ci-no-td Do not run TD on this PR ciflow/h100 labels Jun 17, 2025
@atalman atalman force-pushed the triton_pin_update branch from 948fed7 to 20d198c Compare June 17, 2025 16:19
@atalman atalman changed the title Triton 3.4.0 pin update [TEST] Triton 3.4.0 pin update Jun 17, 2025
@atalman
Copy link
Contributor Author

atalman commented Jun 20, 2025

@pytorchmergebot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 20, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 20, 2025

Successfully rebased triton_pin_update onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout triton_pin_update && git pull --rebase)

@atalman atalman mentioned this pull request Jun 23, 2025
Closed
@atalman atalman mentioned this pull request Jun 24, 2025
Closed
@jataylo
Copy link
Collaborator

jataylo commented Jun 24, 2025

ROCm jobs are failing at this commit @atalman @davidberard98

Last testing we did was with triton-lang/triton@6d5fb9f which was passing on ROCm #155117 there seems to have been a regression in that week of difference.

What should we do here?

@davidberard98
Copy link
Contributor

davidberard98 commented Jun 25, 2025

@atalman @jataylo I think we can try the older commit on which ROCm was passing. As a bonus, it's possible this may skip the commit that is causing the persistent_tma test to fail. IIUC we don't have any other Triton commits that we need, aside from triton-lang/triton#7219 which we would have needed to cherry-pick anyway.

@jataylo
Copy link
Collaborator

jataylo commented Jun 25, 2025

Looks like @iupaikov-amd's PR #155117 which used the proposed commit 5389ed797016010543ef1c7b88efc50f7521cb4e passes ROCm CI.

Can we try a rebase here @atalman ?

@jataylo jataylo added ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 25, 2025
@davidberard98 davidberard98 mentioned this pull request Jun 30, 2025
Closed
23 tasks
atalman
atalman commented Jul 4, 2025
View reviewed changes
@eellison eellison removed their request for review July 16, 2025 15:01
@atalman atalman closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire Awaiting requested review from desertfire desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 is a code owner

@bertmaher bertmaher Awaiting requested review from bertmaher

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/h100 ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @jataylo @davidberard98